Skip to content

[WIP] Enhance workout session management and UI interactions#79

Merged
wulfland merged 3 commits into
fix-workout-statusfrom
copilot/sub-pr-78
Feb 11, 2026
Merged

[WIP] Enhance workout session management and UI interactions#79
wulfland merged 3 commits into
fix-workout-statusfrom
copilot/sub-pr-78

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 11, 2026

Plan to Address PR Review Comments

  • Fix potential infinite loop in WorkoutSession useEffect (lines 106-132)
    • Added useRef to track if auto-start has already been processed
    • Prevents unnecessary re-execution when isActive changes
  • Add default button style resets to .split-card.clickable CSS
    • Reset border, background, padding, color, text-align, appearance
    • Ensures clickable cards render consistently across browsers
  • Clarify completion message text in SplitProgressTracker
    • Changed from "repeat it or start next week's training" to "redo it"
    • More accurate to actual functionality
  • Add safety checks for missing callbacks in handleCardClick
    • Added console warnings when callbacks are undefined
    • Prevents silent failures
    • Updated warning messages to be more specific about impact

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 11, 2026 08:27
…arify text, add safety checks

Co-authored-by: wulfland <5276337+wulfland@users.noreply.github.com>
Co-authored-by: wulfland <5276337+wulfland@users.noreply.github.com>
@wulfland wulfland marked this pull request as ready for review February 11, 2026 08:28
@wulfland wulfland merged commit 8792fb0 into fix-workout-status Feb 11, 2026
@wulfland wulfland deleted the copilot/sub-pr-78 branch February 11, 2026 08:28
Copilot AI requested a review from wulfland February 11, 2026 08:29
Copilot stopped work on behalf of wulfland due to an error February 11, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants