fix: provider should be specified in the config.yaml by alepane21 · Pull Request #1397 · wundergraph/cosmo

alepane21 · 2024-11-24T17:36:58Z

Motivation and Context

When the providers needed by the router are not configured the router should not start, but return an error.

Checklist

I have discussed my proposed changes in an issue and have received approval to proceed.
I have followed the coding standards of the project.
Tests or benchmarks have been added or updated.
Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
I have read the Contributors Guide.

…oes-not-validate-schema-provider-id-is-valid-in-the

…-provider-id-is-valid-in-the

…oes-not-validate-schema-provider-id-is-valid-in-the

…-provider-id-is-valid-in-the

router-tests/testenv/testenv.go

github-actions · 2025-01-01T05:19:15Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

…-provider-id-is-valid-in-the # Conflicts: # connect-go/gen/proto/wg/cosmo/node/v1/node.pb.go # router/gen/proto/wg/cosmo/node/v1/node.pb.go

…-provider-id-is-valid-in-the # Conflicts: # router-tests/events/kafka_events_test.go # router-tests/events/nats_events_test.go

github-actions · 2025-01-03T12:06:20Z

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-4459deac7c5637ee56c33d3d7591082b016022c5

…-provider-id-is-valid-in-the # Conflicts: # router-tests/testenv/testenv.go

…date-schema-provider-id-is-valid-in-the

router-tests/testenv/testenv.go

router/core/graph_server.go

…-provider-id-is-valid-in-the

StarpTech

LGTM

…idate-schema-provider-id-is-valid-in-the' into ale/eng-5932-router-does-not-validate-schema-provider-id-is-valid-in-the

* feat: expose type data and record subgraphs for enums (wundergraph#1495) * chore(release): Publish [skip ci] - cdn@0.12.0 - wgc@0.71.5 - @wundergraph/composition@0.34.0 - controlplane@0.119.0 - @wundergraph/cosmo-shared@0.33.3 - studio@0.97.0 * feat: improve rate limit responses (add code, hide stats) (wundergraph#1497) * chore(release): Publish [skip ci] - router@0.161.0 * fix: provider should be specified in the config.yaml (wundergraph#1397) * fix: update the timeouts for clickhouse and platform service (wundergraph#1500) * chore(release): Publish [skip ci] - wgc@0.71.6 - controlplane@0.119.1 - router@0.161.1 * fix: add edfs to the demo environment (wundergraph#1505) * docs(CONTRIBUTING): fixup minor mistake in CONTRIBUTING.md under Go workspace (wundergraph#1502) Co-authored-by: Dustin Deus <deusdustin@gmail.com> * fix: full demo broken in main branch (wundergraph#1508) * feat(router): optionally add jitter to config polling interval (wundergraph#1506) Co-authored-by: Dustin Deus <deusdustin@gmail.com> * chore(release): Publish [skip ci] - router@0.162.0 * fix(router): remove wildcard from router graphql path (wundergraph#1509) * fix: use gauge for server.uptime metric (wundergraph#1510) Co-authored-by: Ludwig <ludwig.bedacht@gmail.com> * feat: cache warmer (wundergraph#1501) Co-authored-by: Ludwig <ludwig.bedacht@gmail.com> Co-authored-by: starptech <deusdustin@gmail.com> * chore(release): Publish [skip ci] - cdn@0.13.0 - @wundergraph/cosmo-cdn@0.8.0 - wgc@0.72.0 - @wundergraph/cosmo-connect@0.91.0 - controlplane@0.120.0 - graphqlmetrics@0.32.0 - router@0.163.0 - @wundergraph/cosmo-shared@0.33.4 - studio@0.98.0 * fix(cache warmup): consider only po of the last 7 days (wundergraph#1513) * chore(release): Publish [skip ci] - controlplane@0.120.1 * fix(cache operation): swallow cache errors and other improvements (wundergraph#1515) * chore(release): Publish [skip ci] - controlplane@0.120.2 - graphqlmetrics@0.32.1 - router@0.163.1 - studio@0.98.1 * feat: add variables remapping support (wundergraph#1516) Co-authored-by: starptech <deusdustin@gmail.com> * chore(release): Publish [skip ci] - router@0.164.0 * fix(router): write proper line endings and header for multipart (wundergraph#1517) * chore(release): Publish [skip ci] - router@0.164.1 * feat(router): optimize playground delivery, add concurrency_limit to config (wundergraph#1519) * fix(router): enable health checks during startup (wundergraph#1529) * feat: improve cache warmer (wundergraph#1530) Co-authored-by: Ludwig <ludwig.bedacht@gmail.com> * chore(release): Publish [skip ci] - controlplane@0.121.0 - router@0.165.0 - studio@0.99.0 * fix: remove semaphore from ResolveGraphQLSubscription (wundergraph#1532) * chore(release): Publish [skip ci] - router@0.165.1 * feat: add compatibility handshake between router and execution config (wundergraph#1534) * chore(release): Publish [skip ci] - wgc@0.72.1 - @wundergraph/composition@0.35.0 - @wundergraph/cosmo-connect@0.92.0 - controlplane@0.121.1 - router@0.166.0 - @wundergraph/cosmo-shared@0.34.0 - studio@0.99.1 * feat: also add handshake for static execution configs (wundergraph#1535) * chore(router): bump demo library to pickup subscription fix (wundergraph#1518) * feat(router): add interface for trace propagation (wundergraph#1526) * chore(release): Publish [skip ci] - router@0.167.0 * fix: adding/removing directive is not picked up by wgc subgraph check (wundergraph#1494) * chore(deps): upgrade ristretto to v2 (wundergraph#1538) * feat: add normalizedQuery to query plan and request info to trace (wundergraph#1536) Co-authored-by: df-wg <dave@wundergraph.com> * fix: add copy button to subgraph routing url (wundergraph#1543) Co-authored-by: Dustin Deus <deusdustin@gmail.com> * fix: webhooks shot when schema is unchanged (wundergraph#1542) * fix: trim the inputs of group mappers (wundergraph#1541) * fix: subgraphs search functionality (wundergraph#1540) * chore(release): Publish [skip ci] - controlplane@0.121.2 - graphqlmetrics@0.32.2 - router@0.168.0 - studio@0.99.2 * fix: increase max concurrent resolvers (wundergraph#1544) * refactor(router): redesign JWK authentication logic (wundergraph#1498) * chore(release): Publish [skip ci] - router@0.168.1 * fix: increase the test timeout value to prevent failures on slower machines (wundergraph#1547) * fix: reduce the breaking change retention duration (wundergraph#1550) * fix: change the defaults of breaking-change-retention (wundergraph#1551) * feat(router): enable starting the router without subgraphs (wundergraph#1533) * fix(router): parse accept header per rfc 9110 (wundergraph#1549) * chore(release): Publish [skip ci] - controlplane@0.121.3 - router@0.169.0 - studio@0.99.3 * feat(router): enable using redis clusters for rate limiting and apq (wundergraph#1499) * fix: json schema for traffic shaping subgraphs (wundergraph#1552) * chore: Update aws-lambda-router customisation after upstream sync --------- Co-authored-by: Nithin Kumar B <nithinkumar5353@gmail.com> Co-authored-by: hardworker-bot <bot@wundergraph.com> Co-authored-by: Jens Neuse <jens.neuse@gmx.de> Co-authored-by: Alessandro Pagnin <ale@wundergraph.com> Co-authored-by: Suvij Surya <suvijsurya76@gmail.com> Co-authored-by: endigma <endigma@mailcat.ca> Co-authored-by: Dustin Deus <deusdustin@gmail.com> Co-authored-by: Ludwig <ludwig.bedacht@gmail.com> Co-authored-by: Sergiy 🇺🇦 <818351+devsergiy@users.noreply.github.com> Co-authored-by: df-wg <dave@wundergraph.com> Co-authored-by: Aenimus <47415099+Aenimus@users.noreply.github.com>

* feat: expose type data and record subgraphs for enums (wundergraph#1495) * chore(release): Publish [skip ci] - cdn@0.12.0 - wgc@0.71.5 - @wundergraph/composition@0.34.0 - controlplane@0.119.0 - @wundergraph/cosmo-shared@0.33.3 - studio@0.97.0 * feat: improve rate limit responses (add code, hide stats) (wundergraph#1497) * chore(release): Publish [skip ci] - router@0.161.0 * fix: provider should be specified in the config.yaml (wundergraph#1397) * fix: update the timeouts for clickhouse and platform service (wundergraph#1500) * chore(release): Publish [skip ci] - wgc@0.71.6 - controlplane@0.119.1 - router@0.161.1 * fix: add edfs to the demo environment (wundergraph#1505) * docs(CONTRIBUTING): fixup minor mistake in CONTRIBUTING.md under Go workspace (wundergraph#1502) Co-authored-by: Dustin Deus <deusdustin@gmail.com> * fix: full demo broken in main branch (wundergraph#1508) * feat(router): optionally add jitter to config polling interval (wundergraph#1506) Co-authored-by: Dustin Deus <deusdustin@gmail.com> * chore(release): Publish [skip ci] - router@0.162.0 * fix(router): remove wildcard from router graphql path (wundergraph#1509) * fix: use gauge for server.uptime metric (wundergraph#1510) Co-authored-by: Ludwig <ludwig.bedacht@gmail.com> * feat: cache warmer (wundergraph#1501) Co-authored-by: Ludwig <ludwig.bedacht@gmail.com> Co-authored-by: starptech <deusdustin@gmail.com> * chore(release): Publish [skip ci] - cdn@0.13.0 - @wundergraph/cosmo-cdn@0.8.0 - wgc@0.72.0 - @wundergraph/cosmo-connect@0.91.0 - controlplane@0.120.0 - graphqlmetrics@0.32.0 - router@0.163.0 - @wundergraph/cosmo-shared@0.33.4 - studio@0.98.0 * fix(cache warmup): consider only po of the last 7 days (wundergraph#1513) * chore(release): Publish [skip ci] - controlplane@0.120.1 * fix(cache operation): swallow cache errors and other improvements (wundergraph#1515) * chore(release): Publish [skip ci] - controlplane@0.120.2 - graphqlmetrics@0.32.1 - router@0.163.1 - studio@0.98.1 * feat: add variables remapping support (wundergraph#1516) Co-authored-by: starptech <deusdustin@gmail.com> * chore(release): Publish [skip ci] - router@0.164.0 * fix(router): write proper line endings and header for multipart (wundergraph#1517) * chore(release): Publish [skip ci] - router@0.164.1 * feat(router): optimize playground delivery, add concurrency_limit to config (wundergraph#1519) * fix(router): enable health checks during startup (wundergraph#1529) * feat: improve cache warmer (wundergraph#1530) Co-authored-by: Ludwig <ludwig.bedacht@gmail.com> * chore(release): Publish [skip ci] - controlplane@0.121.0 - router@0.165.0 - studio@0.99.0 * fix: remove semaphore from ResolveGraphQLSubscription (wundergraph#1532) * chore(release): Publish [skip ci] - router@0.165.1 * feat: add compatibility handshake between router and execution config (wundergraph#1534) * chore(release): Publish [skip ci] - wgc@0.72.1 - @wundergraph/composition@0.35.0 - @wundergraph/cosmo-connect@0.92.0 - controlplane@0.121.1 - router@0.166.0 - @wundergraph/cosmo-shared@0.34.0 - studio@0.99.1 * feat: also add handshake for static execution configs (wundergraph#1535) * chore(router): bump demo library to pickup subscription fix (wundergraph#1518) * feat(router): add interface for trace propagation (wundergraph#1526) * chore(release): Publish [skip ci] - router@0.167.0 * fix: adding/removing directive is not picked up by wgc subgraph check (wundergraph#1494) * chore(deps): upgrade ristretto to v2 (wundergraph#1538) * feat: add normalizedQuery to query plan and request info to trace (wundergraph#1536) Co-authored-by: df-wg <dave@wundergraph.com> * fix: add copy button to subgraph routing url (wundergraph#1543) Co-authored-by: Dustin Deus <deusdustin@gmail.com> * fix: webhooks shot when schema is unchanged (wundergraph#1542) * fix: trim the inputs of group mappers (wundergraph#1541) * fix: subgraphs search functionality (wundergraph#1540) * chore(release): Publish [skip ci] - controlplane@0.121.2 - graphqlmetrics@0.32.2 - router@0.168.0 - studio@0.99.2 * fix: increase max concurrent resolvers (wundergraph#1544) * refactor(router): redesign JWK authentication logic (wundergraph#1498) * chore(release): Publish [skip ci] - router@0.168.1 * fix: increase the test timeout value to prevent failures on slower machines (wundergraph#1547) * fix: reduce the breaking change retention duration (wundergraph#1550) * fix: change the defaults of breaking-change-retention (wundergraph#1551) * feat(router): enable starting the router without subgraphs (wundergraph#1533) * fix(router): parse accept header per rfc 9110 (wundergraph#1549) * chore(release): Publish [skip ci] - controlplane@0.121.3 - router@0.169.0 - studio@0.99.3 * feat(router): enable using redis clusters for rate limiting and apq (wundergraph#1499) * fix: json schema for traffic shaping subgraphs (wundergraph#1552) * fix: subgraph timeout can't be bigger than global timeout (wundergraph#1548) * fix: error when graph token is not set when cache warmup is enabled (wundergraph#1554) * chore(release): Publish [skip ci] - router@0.170.0 * fix: incorrect graphql endpoint in playground (wundergraph#1562) * chore(release): Publish [skip ci] - @wundergraph/playground@0.8.3 - router@0.170.1 * fix: update vulnerable packages (wundergraph#1560) * fix: synchronize go mod versions (wundergraph#1564) * chore: reduce verbose logging for failed tests (wundergraph#1565) * fix: Add missing config mapping, bump aws-lambda-router version * fix: Repair PNPM lockfile after merge --------- Co-authored-by: Nithin Kumar B <nithinkumar5353@gmail.com> Co-authored-by: hardworker-bot <bot@wundergraph.com> Co-authored-by: Jens Neuse <jens.neuse@gmx.de> Co-authored-by: Alessandro Pagnin <ale@wundergraph.com> Co-authored-by: Suvij Surya <suvijsurya76@gmail.com> Co-authored-by: endigma <endigma@mailcat.ca> Co-authored-by: Dustin Deus <deusdustin@gmail.com> Co-authored-by: Ludwig <ludwig.bedacht@gmail.com> Co-authored-by: Sergiy 🇺🇦 <818351+devsergiy@users.noreply.github.com> Co-authored-by: df-wg <dave@wundergraph.com> Co-authored-by: Aenimus <47415099+Aenimus@users.noreply.github.com>

fix: provider should be specified in the config.yaml

2c28b2a

github-actions bot added the router label Nov 24, 2024

alepane21 added 2 commits November 27, 2024 23:43

Merge remote-tracking branch 'origin/main' into ale/eng-5932-router-d…

949ec88

…oes-not-validate-schema-provider-id-is-valid-in-the

Merge branch 'main' into ale/eng-5932-router-does-not-validate-schema…

b61f8ab

…-provider-id-is-valid-in-the

alepane21 marked this pull request as draft December 3, 2024 14:54

alepane21 added 2 commits December 6, 2024 15:23

Merge remote-tracking branch 'origin/main' into ale/eng-5932-router-d…

bb91fe1

…oes-not-validate-schema-provider-id-is-valid-in-the

chore: don't verify pubsub providers on tests by default

cf2179a

github-actions bot added protocol connect labels Dec 6, 2024

alepane21 marked this pull request as ready for review December 9, 2024 11:08

Merge branch 'main' into ale/eng-5932-router-does-not-validate-schema…

3e1e21e

…-provider-id-is-valid-in-the

StarpTech requested changes Dec 11, 2024

View reviewed changes

router-tests/testenv/testenv.go Outdated Show resolved Hide resolved

github-actions bot added the Stale label Jan 1, 2025

alepane21 added 2 commits January 3, 2025 11:08

Merge branch 'main' into ale/eng-5932-router-does-not-validate-schema…

f9b2f5b

…-provider-id-is-valid-in-the # Conflicts: # connect-go/gen/proto/wg/cosmo/node/v1/node.pb.go # router/gen/proto/wg/cosmo/node/v1/node.pb.go

feat: generate configs for edfs

3711d6a

github-actions bot removed the protocol label Jan 3, 2025

Merge branch 'main' into ale/eng-5932-router-does-not-validate-schema…

47ad9ff

…-provider-id-is-valid-in-the # Conflicts: # router-tests/events/kafka_events_test.go # router-tests/events/nats_events_test.go

chore: missing pnpm build in connect

74730fb

github-actions bot removed the connect label Jan 3, 2025

Merge branch 'main' into ale/eng-5932-router-does-not-validate-schema…

8e15805

…-provider-id-is-valid-in-the # Conflicts: # router-tests/testenv/testenv.go

alepane21 requested review from StarpTech and devsergiy January 3, 2025 14:04

github-actions bot removed the Stale label Jan 4, 2025

alepane21 added 4 commits January 8, 2025 10:37

Merge branch 'refs/heads/main' into ale/eng-5932-router-does-not-vali…

89c9028

…date-schema-provider-id-is-valid-in-the

fix: remove dev file

fb8801d

fix: restore default router.yaml

1a86575

fix: restore default config.yaml

6e17455

StarpTech requested changes Jan 8, 2025

View reviewed changes

router-tests/testenv/testenv.go Outdated Show resolved Hide resolved

router/core/graph_server.go Outdated Show resolved Hide resolved

chore: improve error message

68653ec

alepane21 requested a review from StarpTech January 8, 2025 13:42

alepane21 and others added 2 commits January 8, 2025 17:46

fix: rr.Start usage

2c4dc6b

Merge branch 'main' into ale/eng-5932-router-does-not-validate-schema…

1277f89

…-provider-id-is-valid-in-the

StarpTech approved these changes Jan 8, 2025

View reviewed changes

alepane21 added 2 commits January 8, 2025 18:10

fix: remove now useless kafka container

5d8d795

Merge remote-tracking branch 'origin/ale/eng-5932-router-does-not-val…

879964d

…idate-schema-provider-id-is-valid-in-the' into ale/eng-5932-router-does-not-validate-schema-provider-id-is-valid-in-the

alepane21 merged commit 7f0f4bb into main Jan 8, 2025
13 checks passed

alepane21 deleted the ale/eng-5932-router-does-not-validate-schema-provider-id-is-valid-in-the branch January 8, 2025 17:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: provider should be specified in the config.yaml#1397

fix: provider should be specified in the config.yaml#1397
alepane21 merged 20 commits intomainfrom
ale/eng-5932-router-does-not-validate-schema-provider-id-is-valid-in-the

alepane21 commented Nov 24, 2024 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Jan 1, 2025

Uh oh!

github-actions bot commented Jan 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

StarpTech left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

alepane21 commented Nov 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Checklist

Uh oh!

Uh oh!

github-actions bot commented Jan 1, 2025

Uh oh!

github-actions bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Router image scan passed

Uh oh!

Uh oh!

Uh oh!

StarpTech left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alepane21 commented Nov 24, 2024 •

edited

Loading

github-actions bot commented Jan 3, 2025 •

edited

Loading