Closed
Conversation
- wgc@0.88.1 - @wundergraph/protographic@0.6.0 - router@0.238.0
- wgc@0.88.2 - @wundergraph/protographic@0.7.0 - router@0.239.0
The OperationKit.unmarshalOperation method checks if non-empty sha256 hash in GraphQLRequestExtensions.PersistedQuery.Sha256Hash is valid. It rejects hex strings that could not be sha256 hash and raises en error that it cannot parse the body. I have decided to do strict validation for SHA-256 hashes. I kept the old behvaiour of not accepting an empty hash value as valid. Tests now deal only with valid hash values. I have changed how we handle errors returned by operationKit.UnmarshalOperation* methods. Now the client will see the error returned by the "UnmarshalOperationFromBody". I added a couple of tests for "UnmarshalOperationFromURL".
- router@0.239.1
- router@0.239.2
- router@0.239.3
When operation names are sent to downstream subgraphs, send them in the
following format:
$operationName__$subgraphName__$fetchID
- router@0.239.4
- wgc@0.88.3 - @wundergraph/cosmo-connect@0.115.1 - controlplane@0.154.1 - @wundergraph/protographic@0.7.1 - @wundergraph/cosmo-shared@0.40.1 - studio@0.122.3
- wgc@0.88.4 - @wundergraph/protographic@0.7.2 - router@0.240.0 - router-plugin@0.3.0
- router@0.240.1 - router-plugin@0.3.1
Implement plans for subscriptions. Represent them the same way as Apollo does:
QueryPlan {
Subscription {
Primary: {
Fetch(service: "messages") {
{
messageInConversation(id: $id) {
id
text
sentTime
}
}
}
},
Rest: {
Fetch(service: "employees") {
{
...
}
}
},
}
}
"Primary" key contains the subscription that is setup to receive messages from subgraph.
"Rest" key contains the queries that willl be executed for each received message by the router.
Printing Query Plans was broken for PubSub subscriptions.
From now on, for this type we return empty Fetch node for "Primary" key.
This allows to print QueryPlanner nodes that would not be included because of directives like "skip", "include".
- wgc@0.89.0 - @wundergraph/protographic@0.8.0 - router@0.240.2
This index does not mean anything to the user, so we better remove it.
- router@0.253.1
- router@0.254.0
- router@0.254.1
Noroth
requested review from
a team,
Aenimus,
JivusAyrus,
StarpTech,
alepane21,
devsergiy,
endigma,
jensneuse,
miklosbarabas,
thisisnithin and
wilsonrivera
as code owners
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
github-actions
bot
added
studio
monorepo
controlplane
cli
protocol
connect
router
graphqlmetrics
aws-lambda-router
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subgraph-checkerrole (feat: introduce thesubgraph-checkerrole #2198)@coderabbitai summary
Checklist