Conversation
…6-router-expose-the-static-cost-to-the-middleware
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds end-to-end cost control: new Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Comment |
Router image scan passed✅ No security vulnerabilities found in image: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2470 +/- ##
===========================================
- Coverage 61.79% 24.17% -37.62%
===========================================
Files 231 213 -18
Lines 24143 23652 -491
===========================================
- Hits 14919 5718 -9201
- Misses 7980 17129 +9149
+ Partials 1244 805 -439
🚀 New features to boost your workflow:
|
…6-router-expose-the-static-cost-to-the-middleware
…6-router-expose-the-static-cost-to-the-middleware
…6-router-expose-the-static-cost-to-the-middleware
…6-router-expose-the-static-cost-to-the-middleware
…6-router-expose-the-static-cost-to-the-middleware
…6-router-expose-the-static-cost-to-the-middleware
Integrate static and dynamic cost calculation into the router.
Expose the static (estimated) cost value in the modules.
Expose both costs via telemetry and response headers.
Metrics for costs should be enabled individually in the corresponding telemetry section.
Composition was reviewed in another PR and merged here.
End-to-end benchmark for a big query to measure the impact of cost control:
│ SequentialBig │ SequentialBigCostAnalysis │
│ sec/op │ sec/op vs base │
*-14 584.1µ ± 0% 586.7µ ± 0% +0.45% (p=0.000 n=40)
│ SequentialBig │ SequentialBigCostAnalysis │
│ B/s │ B/s vs base │
*-14 5.527Mi ± 0% 5.503Mi ± 0% -0.43% (p=0.000 n=40)
│ SequentialBig │ SequentialBigCostAnalysis │
│ B/op │ B/op vs base │
*-14 456.1Ki ± 0% 456.1Ki ± 0% ~ (p=0.822 n=40)
│ SequentialBig │ SequentialBigCostAnalysis │
│ allocs/op │ allocs/op vs base │
*-14 6.444k ± 0% 6.452k ± 0% +0.12% (p=0.000 n=40)
Fixes ENG-8844
Fixes ENG-8986
Co-authored-by: Aenimus <47415099+Aenimus@users.noreply.github.com>
Co-authored-by: StarpTech <deusdustin@gmail.com>
Integrate static and dynamic cost calculation into the router.
Expose the static (estimated) cost value in the modules.
Expose both costs via telemetry and response headers.
Metrics for costs should be enabled individually in the corresponding telemetry section.
Composition was reviewed in another PR and merged here.
I have added end-to-end benchmark for a big query to measure the impact of cost control:
Fixes ENG-8844
Fixes ENG-8986
Summary by CodeRabbit
New Features
Configuration
Metrics
Tests / Docs