chore: include plugin build in setup target

[Noroth]

Summary by CodeRabbit

• Chores
  • Development setup now automatically builds demo plugins so local environments include built plugins after setup.
  • Both development setup variants were updated to run the plugin build step during initialization.
  • CI workflow triggers were broadened so changes to build configuration will rerun the relevant router CI checks.

Checklist

• I have discussed my proposed changes in an issue and have received approval to proceed.
• I have followed the coding standards of the project.
• Tests or benchmarks have been added or updated.
• Documentation has been updated on https://github.com/wundergraph/docs-website.
• I have read the Contributors Guide.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ae309de0-65fc-4a90-9516-7eeac1a53688

📥 Commits

Reviewing files that changed from the base of the PR and between d4d8395 and cc8443f.

📒 Files selected for processing (1)

• .github/workflows/router-ci.yaml

---

Walkthrough

Added a new Makefile target build-plugins that runs $(MAKE) -C demo plugin-build-ci. Updated dev-setup and dev-setup-no-infra to invoke make build-plugins. Also extended workflow path filters to include the Makefile in .github/workflows/router-ci.yaml.

Changes

Cohort / File(s)	Summary
Build configuration Makefile	Added build-plugins target ($(MAKE) -C demo plugin-build-ci). Updated dev-setup and dev-setup-no-infra to call make build-plugins.
CI workflow .github/workflows/router-ci.yaml	Extended pull_request path filters to include the Makefile, so workflow triggers when the Makefile changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: add yes option for router cli and fix ts demo plugin example #2367: Adds/changes demo/Makefile plugin-build-ci targets and CI build variants that are invoked by the new build-plugins Makefile target.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: include plugin build in setup target' accurately reflects the main changes: adding a build-plugins target and integrating it into dev-setup and dev-setup-no-infra targets.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

Makefile (1)

94-95: Consider adding build-plugins to dev-setup-no-infra for consistency.

The dev-setup-no-infra target mirrors most of dev-setup but now lacks the build-plugins step. If plugins are required for development regardless of infrastructure, this target may need updating as well. If the omission is intentional (e.g., plugins require running infrastructure), please disregard.

♻️ Proposed change if plugins should be built in no-infra setup

 dev-setup-no-infra: prerequisites
 	pnpm install
 	pnpm generate
 	make generate-go
 	pnpm -r run --filter '!studio' build
+	make build-plugins

Also applies to: 99-103

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Makefile` around lines 94 - 95, The dev-setup-no-infra Makefile target is
missing the build-plugins step present in dev-setup; update the
dev-setup-no-infra target to depend on or invoke the build-plugins target (add
build-plugins to its dependency list or include the same recipe call) so plugins
are built in the no-infra path; also mirror this change for the similar block
referenced (the other dev-setup-like target around the other occurrence) to keep
both targets consistent.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Makefile`:
- Around line 94-95: The dev-setup-no-infra Makefile target is missing the
build-plugins step present in dev-setup; update the dev-setup-no-infra target to
depend on or invoke the build-plugins target (add build-plugins to its
dependency list or include the same recipe call) so plugins are built in the
no-infra path; also mirror this change for the similar block referenced (the
other dev-setup-like target around the other occurrence) to keep both targets
consistent.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2ac713c4-fc24-4619-8774-13875aee6209

📥 Commits

Reviewing files that changed from the base of the PR and between cd38084 and 7c59c09.

📒 Files selected for processing (1)

• Makefile

[coderabbitai]

CodeRabbit chat interactions are restricted to organization members for this repository. Ask an organization member to interact with CodeRabbit, or set chat.allow_non_org_members: true in your configuration.

[github-actions]

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-4c8066c237acdf90f4aefa5e9b70a2d010fde5ec

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.86%. Comparing base (36cda91) to head (cc8443f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2651   +/-   ##
=======================================
  Coverage   62.85%   62.86%           
=======================================
  Files         244      244           
  Lines       25831    25831           
=======================================
+ Hits        16237    16239    +2     
+ Misses       8259     8257    -2     
  Partials     1335     1335           

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[SkArchon]

lgtm

[jensneuse]

thanks