Conversation
Aenimus
requested review from
JivusAyrus,
StarpTech,
jensneuse and
thisisnithin
as code owners
Contributor
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughRefactors shared-entity root-field resolvability handling: removes inline shared-entity error construction, adds Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~55 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2759 +/- ##
===========================================
- Coverage 64.45% 45.72% -18.73%
===========================================
Files 306 1036 +730
Lines 43621 139222 +95601
Branches 4690 8667 +3977
===========================================
+ Hits 28114 63656 +35542
- Misses 15485 73824 +58339
- Partials 22 1742 +1720
🚀 New features to boost your workflow:
|
Router image scan failed❌ Security vulnerabilities found in image: Please check the security vulnerabilities found in the PR. If you believe this is a false positive, please add the vulnerability to the |
…ted-error-propagation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@composition/src/resolvability-graph/graph.ts`:
- Around line 342-346: The condition checking walker.unresolvablePaths is wrong
because Set.size is never negative; update the short-circuit in the block that
currently reads `if (walker.unresolvablePaths.size < 0)` to check for emptiness
(e.g., `walker.unresolvablePaths.size < 1` or `=== 0`) so the early return {
success: true } executes when there are no unresolvable paths; locate this in
graph.ts near the walker usage and adjust the comparison accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a3a6a96f-b96e-4c31-83b5-ba1ac0e5aeff
📒 Files selected for processing (7)
composition-go/index.global.jscomposition/src/resolvability-graph/graph.tscomposition/src/resolvability-graph/types/types.tscomposition/src/resolvability-graph/utils/types/params.tscomposition/src/resolvability-graph/utils/types/types.tscomposition/src/resolvability-graph/utils/utils.tscomposition/tests/v1/resolvability.test.ts
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
composition/src/resolvability-graph/graph.ts (1)
502-503: Consider adding a guard for emptyentityNodeNames.The non-null assertion
!on line 503 assumesentityNodeNamesis never empty. If it is,getFirstEntryreturnsundefinedand.split()will throw aTypeError.While the calling context likely ensures non-empty sets, a defensive check would make this more robust.
🛡️ Suggested defensive handling
getEntityAncestorCollection(entityNodeNames: Set<NodeName>): EntityAncestorCollection { - const typeName = getFirstEntry(entityNodeNames)!.split(LITERAL_PERIOD)[1]; + const firstEntry = getFirstEntry(entityNodeNames); + if (!firstEntry) { + throw new Error('Fatal: entityNodeNames cannot be empty'); + } + const typeName = firstEntry.split(LITERAL_PERIOD)[1];🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@composition/src/resolvability-graph/graph.ts` around lines 502 - 503, In getEntityAncestorCollection, avoid the unsafe non-null assertion on getFirstEntry(entityNodeNames) by first guarding for an empty entityNodeNames Set: check if entityNodeNames.size === 0 and handle it (e.g., throw a clear error or return an appropriate empty EntityAncestorCollection) before calling getFirstEntry(...). Keep the rest of the logic that splits the returned node name by LITERAL_PERIOD and uses typeName unchanged; reference function getEntityAncestorCollection, helper getFirstEntry, parameter entityNodeNames, and constant LITERAL_PERIOD when applying this fix.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@composition/src/resolvability-graph/graph.ts`:
- Around line 502-503: In getEntityAncestorCollection, avoid the unsafe non-null
assertion on getFirstEntry(entityNodeNames) by first guarding for an empty
entityNodeNames Set: check if entityNodeNames.size === 0 and handle it (e.g.,
throw a clear error or return an appropriate empty EntityAncestorCollection)
before calling getFirstEntry(...). Keep the rest of the logic that splits the
returned node name by LITERAL_PERIOD and uses typeName unchanged; reference
function getEntityAncestorCollection, helper getFirstEntry, parameter
entityNodeNames, and constant LITERAL_PERIOD when applying this fix.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6878389c-c915-463c-af9f-510f465f2127
📒 Files selected for processing (1)
composition/src/resolvability-graph/graph.ts
JivusAyrus
approved these changes
Apr 13, 2026
Aenimus
deleted the
david/eng-9320-short-circuit-before-unvalidated-error-propagation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ty errors
Summary by CodeRabbit
Bug Fixes
Refactor
Tests
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.