feat(router): support dot-path slicingArguments#2831
Conversation
See #2801 for details. This PR merely adds a verifying test and uses the engine with support of this feature.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
WalkthroughAdds a product search API (schema, generated models, resolver) with pagination to the products subgraph, updates graphql-go-tools/v2 dependency in two modules, and adds a router test validating cost estimation for nested input literals. ChangesProduct Search Feature
Dependency & Cost Estimation Update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.1)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
Router-nonroot image scan passed✅ No security vulnerabilities found in image: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2831 +/- ##
===========================================
- Coverage 65.92% 55.53% -10.40%
===========================================
Files 254 238 -16
Lines 26527 25946 -581
===========================================
- Hits 17489 14408 -3081
- Misses 7639 10069 +2430
- Partials 1399 1469 +70 🚀 New features to boost your workflow:
|
|
i will have to make it together with the compsition, it looks like. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
router/go.mod (1)
192-192: 💤 Low valuePotential security concern:
go.opentelemetry.io/otel/sdkpinned below recommended version.The replace directive pins
otel/sdkto v1.28.0, which is below the recommended v1.40.0+ threshold for CVE-2026-24051 (PATH hijacking on macOS/Darwin). While the comment indicates this is intentional to preserve attribute naming, verify this risk is acceptable for your deployment environment.Based on learnings: "In wundergraph/cosmo,
google.golang.org/grpcv1.79.3 can transitively pull a vulnerablego.opentelemetry.io/otel/sdkversion (GHSA-9h8m-3fm2-qjrq / CVE-2026-24051, PATH hijacking on macOS/Darwin). In every modulego.mod, explicitly pingo.opentelemetry.io/otel/sdktov1.40.0or later."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@router/go.mod` at line 192, The replace directive currently pins the module go.opentelemetry.io/otel/sdk to v1.28.0 which is below the recommended safe threshold; update the replace to pin go.opentelemetry.io/otel/sdk to v1.40.0 or later (or remove the replace if not required) and then run go mod tidy to refresh transitive deps; if you must keep v1.28.0 to preserve attribute naming, add a short justification comment and document the risk acceptance for CVE-2026-24051 and validate on macOS/Darwin that no vulnerable code paths exist (and consider adding a TODO to revisit the pin once attribute compatibility is resolved).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@router/go.mod`:
- Line 192: The replace directive currently pins the module
go.opentelemetry.io/otel/sdk to v1.28.0 which is below the recommended safe
threshold; update the replace to pin go.opentelemetry.io/otel/sdk to v1.40.0 or
later (or remove the replace if not required) and then run go mod tidy to
refresh transitive deps; if you must keep v1.28.0 to preserve attribute naming,
add a short justification comment and document the risk acceptance for
CVE-2026-24051 and validate on macOS/Darwin that no vulnerable code paths exist
(and consider adding a TODO to revisit the pin once attribute compatibility is
resolved).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 95398890-0f43-4e4f-97c1-9f207d6f7684
⛔ Files ignored due to path filters (3)
demo/pkg/subgraphs/products/subgraph/generated/generated.gois excluded by!**/generated/**router-tests/go.sumis excluded by!**/*.sumrouter/go.sumis excluded by!**/*.sum
📒 Files selected for processing (7)
demo/pkg/subgraphs/products/subgraph/model/models_gen.godemo/pkg/subgraphs/products/subgraph/schema.graphqlsdemo/pkg/subgraphs/products/subgraph/schema.resolvers.gorouter-tests/go.modrouter-tests/security/costs_test.gorouter-tests/testenv/testdata/config.jsonrouter/go.mod
See #2801 for details.
This PR merely adds a verifying test and uses the engine with support of this feature.
This PR should released before the composition.
Summary by CodeRabbit
New Features
Tests
Chores