Skip to content

Add error for destroy this in constructor, fixes #754 #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2025
Merged

Add error for destroy this in constructor, fixes #754 #1099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
514a86a
add error for destroy this in constructor, fixes #754
Frotty Oct 18, 2025
dcc7f5c
Merge branch 'master' into fix-#754
Frotty Oct 18, 2025
319e316
Update BugTests.java
Frotty Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/validation/WurstValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1863,6 +1863,13 @@ private void visit(ModuleDef moduleDef) {
}

private void visit(ExprDestroy stmtDestroy) {
if (stmtDestroy.getDestroyedObj() instanceof ExprThis) {
if (isInConstructor(stmtDestroy)) {
stmtDestroy.addError("Cannot destroy 'this' in constructor");
return;
}
}

WurstType typ = stmtDestroy.getDestroyedObj().attrTyp();
if (typ instanceof WurstTypeModule) {

Expand Down
15 changes: 14 additions & 1 deletion de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/BugTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1442,7 +1442,6 @@ public void minusRewrite() {
);
}


@Test
public void duplicateNameInClassHierachy() {
testAssertErrorsLines(false, "Variable x in class B hides variable x from superclass A",
Expand All @@ -1459,5 +1458,19 @@ public void duplicateNameInClassHierachy() {
"endpackage");
}

@Test
public void callingDestroyThisInConstructor() {
testAssertErrorsLines(false, "Cannot destroy 'this' in constructor",
"package test",
"native testSuccess()",
"class A",
" construct()",
" destroy this",
"init",
" let b = new A()",
" if b != null",
" testSuccess()",
"endpackage");
}

}
Loading