Skip to content

Conversation

@Thorminator
Copy link

Option for disabling map configuration.

Useful workaround when running and building reforged maps, since their W3I format is not yet supported.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 62.79% when pulling 05daa33 on Thorminator:master into 7f214e6 on wurstscript:master.

@Frotty
Copy link
Member

Frotty commented Nov 23, 2019

Hi, thanks for the PR 👍
The changes themselves look good, but it doesn't seem like the best solution for me.
Probably instead the exception should just be caught and map config not applied when it can't, for whatever unknown issues.
I believe most ppl encountering the issue would not find this config option.

@Thorminator
Copy link
Author

That might be a better approach, I'll rewrite it and open a new PR =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants