Add dev sandbox server and certificate management#3
Merged
Conversation
Introduces a new 'dev serve' command with HTTPS support for local sandboxing, including automatic self-signed certificate generation and platform-specific trust prompts for macOS, Windows, and Linux. Adds dependencies for axum, axum-server, tower, tower-http, rcgen, dialoguer, and mime_guess. Updates README with dev server usage instructions and expands config handling for engine types. Refactors and improves code formatting and error handling in existing modules.
| keyring_service: String, | ||
| #[serde(default)] | ||
| keyring_account: Option<String>, | ||
| keyring_account: String, |
There was a problem hiding this comment.
Bug: Config Defaults Break Keyring Authentication
Changing keyring_service and keyring_account from Option<String> to String with #[serde(default)] breaks the fallback logic. When a config.toml exists without these fields, serde deserializes them to empty strings instead of None. The keyring_config() function no longer calls unwrap_or_else() to apply defaults, causing authentication to fail with empty strings passed to keyring operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new 'dev serve' command with HTTPS support for local sandboxing, including automatic self-signed certificate generation and platform-specific trust prompts for macOS, Windows, and Linux. Adds dependencies for axum, axum-server, tower, tower-http, rcgen, dialoguer, and mime_guess. Updates README with dev server usage instructions and expands config handling for engine types. Refactors and improves code formatting and error handling in existing modules.
Note
Introduces
wvdsh dev serveto host builds locally over HTTPS with auto-generated/trusted certs, CORS, and sandbox URL generation; updates config/engine handling and docs.wvdsh dev serve(Axum + Rustls) to serveupload_dirover HTTPS on a random localhost port.rcgen; prompt to trust on macOS (security), Windows (certutil), and Linux (sudo + CA update).wavedash.ggand subdomains; serves static files with correct headers and compressed asset handling.entrypointParams, and produce a ready-to-click sandbox URL.EngineKindenum withas_config_key/as_label; update build push to use it.keyring_service/keyring_accountconcrete defaults instead of Option.devsubcommand inmain.rs.README.mdwith dev server usage and behavior.axum,axum-server,tower,tower-http,rcgen,dialoguer,mime_guess; bumpserde.Written by Cursor Bugbot for commit 5188443. This will update automatically on new commits. Configure here.