chore: Consolidate Maven organization to org.wvlet.uni#349
Conversation
Update Maven organization from org.wvlet to org.wvlet.uni to better distinguish uni modules from other wvlet projects like Airframe. Also update version references in documentation to 2026.1.0. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @xerial, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request centralizes the Maven organization for all Uni modules under "org.wvlet.uni", aiming to better separate these modules from other projects within the broader "wvlet" ecosystem. This change, along with a version update to "2026.1.0" and a minor artifact name correction, necessitates updates across the build configuration and all relevant documentation, marking a breaking change for existing users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR does a good job of consolidating the Maven organization and updating versions. I've found one minor inconsistency in the documentation that was missed and have a suggestion for a follow-up improvement to enhance project structure consistency.
|
|
||
| ```scala [sbt] | ||
| libraryDependencies += "org.wvlet" %% "uni" % "2025.1.0" | ||
| libraryDependencies += "org.wvlet.uni" %% "uni" % "2026.1.0" |
There was a problem hiding this comment.
Good job updating the dependency snippets! However, I noticed that the module table on line 70 of this file still lists the old artifact name uni-agent-bedrock. To maintain consistency with the other changes in this PR, please update it to uni-bedrock.
- | `uni-agent-bedrock` | AWS Bedrock chat model integration |
+ | `uni-bedrock` | AWS Bedrock chat model integration ||
|
||
| ```scala | ||
| libraryDependencies += "org.wvlet" %% "uni-agent-bedrock" % "2025.1.0" | ||
| libraryDependencies += "org.wvlet.uni" %% "uni-bedrock" % "2026.1.0" |
There was a problem hiding this comment.
The artifact name is now correctly uni-bedrock. For long-term consistency and to avoid confusion for developers, it would be beneficial to also rename the project's source directory from uni-agent-bedrock to uni-bedrock. This would involve updating build.sbt at line 187 and renaming the directory in the file system. This could be handled in a follow-up PR if you prefer to keep this one focused.
// In build.sbt
lazy val bedrock = project
.in(file("uni-bedrock")) // Changed from "uni-agent-bedrock"
// ...Address Gemini review feedback - update module table to show correct artifact name uni-bedrock instead of uni-agent-bedrock. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
org.wvlettoorg.wvlet.unito better distinguish uni modules from other wvlet projects (like Airframe)2026.1.0uni-agent-bedrock→uni-bedrock)Test plan
./sbt compilepasses./sbt scalafmtAllpasses🤖 Generated with Claude Code