feature: Add CollectionWeaver with named weaver classes#383
Conversation
Extract named weaver classes (OptionWeaver, SeqWeaver, MapWeaver, etc.) from anonymous instances in Weaver.scala to improve debuggability and reduce code duplication. Share helper methods (unpackArrayToBuffer, unpackMapToBuffer) between Weaver and PrimitiveWeaver via CollectionWeaver. This follows the pattern from airframe-codec where collection codecs are named classes like SeqCodec, MapCodec, OptionCodec. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
Bot
added
doc
Summary of ChangesHello @xerial, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a great refactoring effort that extracts collection-related weaver logic into a new CollectionWeaver.scala file. This significantly reduces code duplication in Weaver.scala and PrimitiveWeaver.scala, improving maintainability and debuggability by using named classes instead of anonymous ones. The changes are well-executed. I've added a couple of minor suggestions to make the creation of Java collections more concise.
| val list = java.util.ArrayList[Any](buffer.size) | ||
| buffer.foreach(e => list.add(e)) |
There was a problem hiding this comment.
This manual population of the ArrayList can be made more concise by using the constructor that accepts a collection. The asJava converter can be used here to pass the Scala buffer to the Java collection's constructor.
val list = new java.util.ArrayList[Any](buffer.asJava)| val set = java.util.HashSet[Any](buffer.size) | ||
| buffer.foreach(e => set.add(e)) |
There was a problem hiding this comment.
Similar to the JavaListWeaver, this manual population of the HashSet can be simplified by using the constructor that accepts a collection via asJava.
val set = new java.util.HashSet[Any](buffer.asJava)Use ArrayList/HashSet constructors with asJava instead of manual iteration. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 participant
Summary
OptionWeaver,SeqWeaver,MapWeaver,SetWeaver,ArrayWeaver,JavaListWeaver,JavaSetWeaver,JavaMapWeaver) from anonymous instances inWeaver.scalaunpackArrayToBuffer,unpackMapToBuffer) betweenWeaverandPrimitiveWeaverviaCollectionWeaverTest plan
🤖 Generated with Claude Code