Skip to content

feature: Integrate uni-dom into uni module#388

Merged
xerial merged 1 commit intomainfrom
feature/integrate-uni-dom
Jan 31, 2026
Merged

feature: Integrate uni-dom into uni module#388
xerial merged 1 commit intomainfrom
feature/integrate-uni-dom

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Jan 31, 2026

Summary

  • Move uni-dom source files to uni/.js/src/main/scala/wvlet/uni/dom/ as JS-only code
  • Create separate uni-dom-test module for tests requiring JSDOM environment
  • Remove standalone uni-dom module

Motivation

Simplify module structure by integrating the small uni-dom library into the main uni module. The tests require a different JS environment (JSDOM with NoModule), so they are kept in a dedicated test module.

Test plan

  • All 1119 tests pass
  • domTest module runs 55 DOM-specific tests

🤖 Generated with Claude Code

Move uni-dom source files into uni/.js/src/main/scala/wvlet/uni/dom/
as JS-only code. Create separate uni-dom-test module for tests that
require JSDOM environment.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the feature New feature label Jan 31, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @xerial, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the project's module structure by integrating the uni-dom library directly into the uni module. This change aims to simplify the overall architecture and consolidate related functionalities. To accommodate the specific testing requirements of the DOM-related code, a dedicated uni-dom-test module has been created, ensuring that tests needing a JSDOM environment are properly isolated and managed.

Highlights

  • Module Integration: The uni-dom library's source files have been relocated into the uni module, specifically under uni/.js/src/main/scala/wvlet/uni/dom/, making them part of the main uni module as JS-only code.
  • Dedicated Test Module: A new uni-dom-test module has been introduced to house the tests that specifically require a JSDOM environment, separating them from the main uni module's tests.
  • Module Removal: The standalone uni-dom module has been removed, streamlining the project's module structure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully integrates the uni-dom module into the uni module, simplifying the project structure. The changes are well-executed: uni-dom sources are now part of the uni JS project, and a dedicated uni-dom-test module is created for tests requiring JSDOM. The modifications to build.sbt are correct and align with these structural changes. Overall, this is a clean and beneficial refactoring.

@xerial xerial merged commit 61479b7 into main Jan 31, 2026
13 checks passed
@xerial xerial deleted the feature/integrate-uni-dom branch January 31, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant