feature: Integrate uni-dom into uni module#388
Conversation
Move uni-dom source files into uni/.js/src/main/scala/wvlet/uni/dom/ as JS-only code. Create separate uni-dom-test module for tests that require JSDOM environment. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @xerial, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the project's module structure by integrating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully integrates the uni-dom module into the uni module, simplifying the project structure. The changes are well-executed: uni-dom sources are now part of the uni JS project, and a dedicated uni-dom-test module is created for tests requiring JSDOM. The modifications to build.sbt are correct and align with these structural changes. Overall, this is a clean and beneficial refactoring.
Summary
uni/.js/src/main/scala/wvlet/uni/dom/as JS-only codeuni-dom-testmodule for tests requiring JSDOM environmentuni-dommoduleMotivation
Simplify module structure by integrating the small uni-dom library into the main uni module. The tests require a different JS environment (JSDOM with NoModule), so they are kept in a dedicated test module.
Test plan
🤖 Generated with Claude Code