Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes the necessary infrastructure for publishing the project's artifacts to Maven Central. It involves updating build configurations, adding required sbt plugins, defining POM metadata, and setting up automated release workflows to ensure a smooth and signed publication process across JVM, Scala.js, and Scala Native platforms. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request sets up Maven Central publishing by adding the necessary sbt plugins and build configurations. The changes are mostly correct, including the addition of POM metadata. However, I've found a syntax issue in the newly defined sbt command aliases in build.sbt. The + prefix used in the commands is invalid and will cause the aliases to fail. I've provided suggestions to correct the syntax. The rest of the changes for configuring publishing look good.
| "publishSnapshots", | ||
| s"+ projectJVM/publish; + projectJS/publish; + projectNative/publish" |
There was a problem hiding this comment.
The command string for the publishSnapshots alias appears to be incorrect. The + prefix before each command part (e.g., + projectJVM/publish) is not valid sbt syntax for running a task on a project. The + command is for cross-building and should be prefixed to a task (e.g., +publish), not a scoped task key with a space. To run a task on a specific project, you should use the project/task syntax. Since crossScalaVersions contains only one version, cross-building is not necessary.
"publishSnapshots",
s"projectJVM/publish; projectJS/publish; projectNative/publish"
| "publishJSSigned", | ||
| s"+ projectJS/publishSigned" |
There was a problem hiding this comment.
The command string for the publishJSSigned alias appears to be incorrect. The + prefix is not valid sbt syntax. To run a signed publish on the projectJS aggregate, you should use projectJS/publishSigned. The + for cross-building would be projectJS/+publishSigned, but it's not needed here as there's only one Scala version.
"publishJSSigned",
s"projectJS/publishSigned"
| "publishNativeSigned", | ||
| s"+ projectNative/publishSigned" |
There was a problem hiding this comment.
The command string for the publishNativeSigned alias appears to be incorrect. The + prefix is not valid sbt syntax. To run a signed publish on the projectNative aggregate, you should use projectNative/publishSigned. The + for cross-building would be projectNative/+publishSigned, but it's not needed here as there's only one Scala version.
"publishNativeSigned",
s"projectNative/publishSigned"
Add sbt-sonatype and sbt-pgp plugins, configure POM metadata (licenses, homepage, scmInfo, developers), and create GitHub Actions release workflows for JVM, Scala.js, and Scala Native platforms. Releases are triggered by v* tags. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sbt's built-in sonaRelease and localStaging work without the sbt-sonatype plugin. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
f647943 to
0e3f9db
Compare
uni only targets Scala 3, so the + cross-build prefix is not needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove unused SCALA_JS/SCALA_NATIVE env vars from sonaRelease - Add Node.js setup for Scala.js release - Add sbt cache to all release workflows Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Ruby script that auto-increments YYYY.(milestone).patch version, creates an annotated git tag, and pushes to trigger release workflows. Usage: ruby project/release.rb Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
v*tags)publishSnapshots,publishJSSigned,publishNativeSignedFirst release will be
v2026.1.0usingYYYY.(milestone).patchversioning via sbt-dynver.Required GitHub secrets:
PGP_SECRET,PGP_PASSPHRASE,SONATYPE_USER,SONATYPE_PASSTest plan
./sbt compilepasses./sbt scalafmtAllpassesv2026.1.0and verify release workflows run🤖 Generated with Claude Code