internal: Reorganize design package structure and rename tracing components#64
Merged
internal: Reorganize design package structure and rename tracing components#64
Conversation
Contributor
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
| * limitations under the License. | ||
| */ | ||
| package wvlet.ai.design.lifecycle | ||
| package wvlet.ai.design |
Contributor
There was a problem hiding this comment.
Warning
Description: After reviewing your changes for backwards compatibility, the package structure has been modified. Several classes have been moved from 'wvlet.ai.design.lifecycle' and 'wvlet.ai.design.tracing' to 'wvlet.ai.design'. This change may break existing import statements in client code.
Severity: High
Contributor
There was a problem hiding this comment.
Sorry, I'm not able to suggest a fix for this review finding.
Contributor
|
✅ I finished the code review, and left comments with the issues I found. I will now generate code fix suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reorganized the package structure of the design module and renamed components related to tracing for better organization and clarity.
Related Issue/Task
Checklist