Skip to content

feature: Move ULID-related classes to util package #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xerial merged 2 commits into from
May 26, 2025
Merged

feature: Move ULID-related classes to util package #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d39b871
feature: Move ULID related classes to util package
xerial May 26, 2025
5a36afb
maintain the comment
xerial May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../wvlet/ai/core/ulid/CrockfordBase32.scala → .../wvlet/ai/core/util/CrockfordBase32.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package wvlet.ai.core.ulid
package wvlet.ai.core.util

/**
* Base 32 encoding by Douglas Crockford: https://www.crockford.com/base32.html
Expand Down
2 changes: 1 addition & 1 deletion ...ala/wvlet/ai/core/ulid/PrefixedULID.scala → ...ala/wvlet/ai/core/util/PrefixedULID.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package wvlet.ai.core.ulid
package wvlet.ai.core.util

object PrefixedULID:
val DELIMITER = ':'
Expand Down
6 changes: 3 additions & 3 deletions .../main/scala/wvlet/ai/core/ulid/ULID.scala → .../main/scala/wvlet/ai/core/util/ULID.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package wvlet.ai.core.ulid
package wvlet.ai.core.util
Comment thread
xerial marked this conversation as resolved.

import wvlet.ai.core.util.{SecureRandom, ThreadUtil}

Expand Down Expand Up @@ -98,8 +98,8 @@ end ULID
object ULID:
val MinValue: ULID = ULID("00000000000000000000000000")
val MaxValue: ULID = ULID("7ZZZZZZZZZZZZZZZZZZZZZZZZZ")
private[ulid] val MinTime = 0L
private[ulid] val MaxTime = (~0L) >>> (64 - 48) // Timestamp uses 48-bit range
private[util] val MinTime = 0L
private[util] val MaxTime = (~0L) >>> (64 - 48) // Timestamp uses 48-bit range

private var _generator: ULIDGenerator = defaultULIDGenerator

Expand Down
4 changes: 2 additions & 2 deletions ...et/ai/core/ulid/CrockfordBase32Test.scala → ...et/ai/core/util/CrockfordBase32Test.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package wvlet.ai.core.ulid
package wvlet.ai.core.util

import wvlet.ai.core.ulid.CrockfordBase32
import wvlet.ai.core.util.CrockfordBase32
import wvlet.airspec.AirSpec
import wvlet.airspec.spi.PropertyCheck

Expand Down
4 changes: 2 additions & 2 deletions ...wvlet/ai/core/ulid/PrefixedULIDTest.scala → ...wvlet/ai/core/util/PrefixedULIDTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package wvlet.ai.core.ulid
package wvlet.ai.core.util

import wvlet.ai.core.ulid.{PrefixedULID, ULID}
import wvlet.ai.core.util.{PrefixedULID, ULID}
import wvlet.airspec.AirSpec
import wvlet.airspec.spi.PropertyCheck

Expand Down
4 changes: 2 additions & 2 deletions ...t/scala/wvlet/ai/core/ulid/ULIDTest.scala → ...t/scala/wvlet/ai/core/util/ULIDTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package wvlet.ai.core.ulid
package wvlet.ai.core.util

import wvlet.ai.core.ulid.{CrockfordBase32, ULID}
import wvlet.ai.core.util.{CrockfordBase32, ULID}
import wvlet.airspec.AirSpec
import wvlet.airspec.spi.PropertyCheck

Expand Down
Loading