LocalContainer not adhering to specifications

[mariobodemann]

While testing the wrapper we found that the initial implementation needed some more love.

This PR fixes cruicial local container creation, and adds love.

[mariobodemann]

Executing the test locally (revolutionary concept):

JS bridge error. expected:<"[]"> but was:<"[Exception: {\"message\":\"Failed to set the 'innerHTML' property on 'Element': This document requires 'TrustedHTML' assignment.\"}]">
at org.junit.Assert.assertEquals(Assert.java:117)
at com.yubico.ykbrowser.StartUpTest.javascriptInjectionIsCorrect(StartUpTest.kt:91)

I.e. someone from the maintainers (@tladesignz, or @jessevanmuijden maybe?) need to see how to fix the frontend requiring TrustedHTML in combination with adding the debug icon to the dom.

Good luck.

[mariobodemann]

I am not sure if I get the intent of the proposed changes. See inline for detailed feedback.

[jessevanmuijden]

@mariobodemann the proposed changes were just a suggestion to replace nested if statements with early returns for readability.

[mariobodemann]

Ah, I get the intent.

But that wouldn't work. In your suggestions you'll call the callbacks but you aren't exiting the function.

You'd need an explicit return, or nested ifs with the right value returned.