fix(remote-auth): fix the docs for Store API (for extract method)#117
Open
maxkoryukov wants to merge 2 commits intowwebjs:mainfrom
Open
fix(remote-auth): fix the docs for Store API (for extract method)#117maxkoryukov wants to merge 2 commits intowwebjs:mainfrom
extract method)#117maxkoryukov wants to merge 2 commits intowwebjs:mainfrom
Conversation
external store's `extract` receives { session, path} as options.
Update authentication.md
👷 Deploy request for wwebjs pending review.Visit the deploys page to approve it
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the documentation for the RemoveAuth in the js-snippet for the "external store interface" the method
extractdoesn't show the full{ session, path }input for theoptionsparameter.I was implementing a custom store based on docs, and ignored
path, and my store became broken, so i needed to compare to "mongo store" to find the bug. It turned out that the documentation is not full.I hope this PR fixes it
Update authentication.md