Replace Suspense with CSS skeleton loader and simplify loading behavior#32
Merged
NicolasDevil merged 2 commits intowxsub:mainfrom Mar 17, 2026
Merged
Replace Suspense with CSS skeleton loader and simplify loading behavior#32NicolasDevil merged 2 commits intowxsub:mainfrom
NicolasDevil merged 2 commits intowxsub:mainfrom
Conversation
Comment out the Suspense-based dynamic component loader and instead render a static .formkit-module-loading element as a placeholder. Simplify and modernize the loader styles: remove the absolute ::after overlay, switch to a moving background-gradient animation, add min-height and adjust keyframes. Keeps the original Suspense block commented for reference.
Uncomment the <Suspense> wrapper around the dynamic component so its fallback loader is used only while async components load. Remove the redundant .formkit-module-loading div that was always visible, preventing duplicate loading indicators and restoring intended Suspense behavior when conf.type is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.