Replace Suspense with CSS skeleton loader and simplify loading behavior#33
Merged
NicolasDevil merged 1 commit intowxsub:mainfrom Mar 17, 2026
Merged
Replace Suspense with CSS skeleton loader and simplify loading behavior#33NicolasDevil merged 1 commit intowxsub:mainfrom
NicolasDevil merged 1 commit intowxsub:mainfrom
Conversation
Replace the hasOwnProperty check in the watcher with a simple truthy check on the incoming value. Previously the watcher invoked searchRemoteMethod whenever the prop existed (even if undefined), which could trigger unnecessary calls; now the remote search is only called when initialValue is truthy (non-null/undefined/non-empty). Note: this changes behavior for falsy values like 0 or empty string, which will no longer trigger the search.
Contributor
Author
|
if (Object.prototype.hasOwnProperty.call(props, 'initialValue')) { This if condition will always be true. |
Contributor
you are right |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hasOwnProperty check in the watcher with a simple truthy check on the incoming value. Previously the watcher invoked searchRemoteMethod whenever the prop existed (even if undefined), which could trigger unnecessary calls; now the remote search is only called when initialValue is truthy (non-null/undefined/non-empty). Note: this changes behavior for falsy values like 0 or empty string, which will no longer trigger the search.