feat: add default_state option to popup actions#2010
Merged
aklinker1 merged 6 commits intowxt-dev:mainfrom Apr 26, 2026
Merged
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kairi003
force-pushed
the
fix/add-action-default-state
branch
2 times, most recently
from
e7727f5 to
a22fe24
Compare
kairi003
force-pushed
the
fix/add-action-default-state
branch
from
a22fe24 to
f6c380e
Compare
aklinker1
requested changes
Feb 9, 2026
Member
aklinker1
left a comment
aklinker1
left a comment
There was a problem hiding this comment.
Just undo your change to the browser package and add a @ts-expect-error like mentioned in the comemnt. Then I'll approve!
Sorry for the delay, and thanks for opening a PR 😄
Collaborator
|
@kairi003 Are you want to go on? |
Collaborator
|
@kairi003 One more poke :) |
kairi003
force-pushed
the
fix/add-action-default-state
branch
3 times, most recently
from
63ceef1 to
b2239f4
Compare
Contributor
Author
|
@aklinker1 @PatrykKuniczak |
PatrykKuniczak
requested changes
Apr 24, 2026
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Collaborator
Collaborator
|
@kairi003 WAIT, tests issue. |
Contributor
Author
@PatrykKuniczak |
Collaborator
This reverts commit 02a2134.
kairi003
force-pushed
the
fix/add-action-default-state
branch
from
737ced9 to
4101aea
Compare
aklinker1
approved these changes
Apr 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2010 +/- ##
==========================================
+ Coverage 79.58% 79.67% +0.08%
==========================================
Files 130 130
Lines 3802 3804 +2
Branches 860 861 +1
==========================================
+ Hits 3026 3031 +5
+ Misses 691 689 -2
+ Partials 85 84 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for helping make WXT better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for the
default_stateoption in popup actions (browser_action/page_action for MV2, action for MV3). This option controls the initial enabled/disabled state of the extension's action button, as documented in the Chrome Extension Action API.Previously, WXT did not support configuring this property in the manifest, making it impossible to set the action button to a disabled state before any runtime methods are called. This PR allows setting the initial state declaratively in the entrypoint options, following the same pattern as the existing options.
Changes
defaultStateproperty toPopupEntrypointOptionstypedefault_statewhen specifiedManual Testing
Verified in
wxt-demo:default_state: "disabled"towxt.config.tsmanifest configurationdefault_stateproperty is correctly included in the generatedmanifest.jsonRelated Issue
No related issue - this is a standalone enhancement to improve manifest configuration options.