chore: add missing async to network.ts

[PatrykKuniczak]

No description provided.

[netlify]

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name	Link
🔨 Latest commit	bfb4021
🔍 Latest deploy log	https://app.netlify.com/projects/creative-fairy-df92c4/deploys/698f16030dbba30008b91b9e
😎 Deploy Preview	https://deploy-preview-2107--creative-fairy-df92c4.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[pkg-pr-new]

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2107

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2107

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2107

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2107

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2107

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2107

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2107

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2107

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2107

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2107

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2107

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2107

wxt

npm i https://pkg.pr.new/wxt@2107

commit: bfb4021

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.23%. Comparing base (2e2272d) to head (bfb4021).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/wxt/src/core/utils/network.ts	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
+ Coverage   76.14%   76.23%   +0.08%     
==========================================
  Files         113      113              
  Lines        3031     3034       +3     
  Branches      680      680              
==========================================
+ Hits         2308     2313       +5     
  Misses        639      639              
+ Partials       84       82       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aklinker1]

This function doesn't await anything, so it doesn't need to be async. If you want to refactor the rest of the function to use try/catch and await, then the function needs to be async. But it's fine for now.

My editor also recommended this change, but I didn't add it for this reason in my async/await cleanup PR.

[PatrykKuniczak]

@aklinker1 It'll be ok, if i'm add tests for network in new PR, and there only try/catch?
Or tests isn't necessary?

[aklinker1]

It'll be ok, if i'm add tests for network in new PR, and there only try/catch?
Or tests isn't necessary?

Sorry, I don't understand your question

[PatrykKuniczak]

@aklinker1 I want to add try/catch in this PR.
And in other tests for entire network.ts(If this could be helpful, if not, don't mind)

[aklinker1]

Good to go after the one recommended change.

I want to add try/catch in this PR.

OK, sounds good.

And in other tests for entire network.ts(If this could be helpful, if not, don't mind)

Not sure what you mean by this, where is an example?

[aklinker1]

Just missing an import for consola

[PatrykKuniczak]

@aklinker1 OH yeah

[github-actions]

Thanks for helping make WXT better!