Skip to content

chore: Remove any from i18n's internal types#2201

Merged
aklinker1 merged 2 commits intomainfrom
i18n-internal-any-removal
Mar 19, 2026
Merged

chore: Remove any from i18n's internal types#2201
aklinker1 merged 2 commits intomainfrom
i18n-internal-any-removal

Conversation

@aklinker1
Copy link
Member

Overview

Pulled the internal changes out of #2121 so they can be merged while we discuss the other changes in that PR.

CC @PatrykKuniczak

Manual Testing

N/A - See PR checks

Related Issue

Co-Authored-By: Patryk Kuniczak <p.kuniczak@gmail.com>
@netlify
Copy link

netlify bot commented Mar 18, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit a820f66
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/69bb1ff2e5525c0008127a32
😎 Deploy Preview https://deploy-preview-2201--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the pkg/i18n Includes changes to the `packages/i18n` directory label Mar 18, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 18, 2026

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2201

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2201

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2201

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2201

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2201

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2201

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2201

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2201

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2201

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2201

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2201

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2201

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2201

wxt

npm i https://pkg.pr.new/wxt@2201

commit: a820f66

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.35%. Comparing base (ace6c20) to head (a820f66).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2201      +/-   ##
==========================================
+ Coverage   76.29%   76.35%   +0.06%     
==========================================
  Files         115      115              
  Lines        3092     3092              
  Branches      684      684              
==========================================
+ Hits         2359     2361       +2     
+ Misses        651      649       -2     
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aklinker1 aklinker1 marked this pull request as ready for review March 18, 2026 22:00
| Message[]
| { [key: string]: Message };

export type MessagesObject = Record<string, Message>;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a separate type for the messages file contents, referred to as MessagesObject further down (see existing parseMessagesObject function). Couldn't think of a better name for this.

Copy link
Collaborator

@PatrykKuniczak PatrykKuniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aklinker1 aklinker1 merged commit c6c9f65 into main Mar 19, 2026
18 checks passed
@aklinker1 aklinker1 deleted the i18n-internal-any-removal branch March 19, 2026 08:22
@github-actions
Copy link
Contributor

Thanks for helping make WXT better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/i18n Includes changes to the `packages/i18n` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants