Skip to content

Upgrade elixir to v1.12#133

Merged
grzuy merged 5 commits intomasterfrom
elixir-1-12
Sep 16, 2021
Merged

Upgrade elixir to v1.12#133
grzuy merged 5 commits intomasterfrom
elixir-1-12

Conversation

@grzuy
Copy link
Copy Markdown
Contributor

@grzuy grzuy commented Sep 15, 2021

  • Fix any compilation warnings coming from this app
  • Fix any failing tests
  • Check changelog entry

@grzuy
Copy link
Copy Markdown
Contributor Author

grzuy commented Sep 15, 2021

Test failing because elixir no longer sorts binding, intentionally: elixir-lang/elixir@f0b227d.

I need to update tests so that they don't depend on order or apply sorting in the app if that affects the way they are displayed in the sidebar.

@grzuy grzuy force-pushed the elixir-1-12 branch 2 times, most recently from c4523e4 to 09e1c66 Compare September 15, 2021 20:01
@grzuy grzuy marked this pull request as ready for review September 15, 2021 20:10
@eldano
Copy link
Copy Markdown
Contributor

eldano commented Sep 16, 2021

Elixir 1.12 added support for stepped ranges, we need to add support for them.

@grzuy
Copy link
Copy Markdown
Contributor Author

grzuy commented Sep 16, 2021

Elixir 1.12 added support for stepped ranges, we need to add support for them.

Oh right, I assumed they were going to work out of the box, but you're right. They're not working.
Thanks!

@grzuy
Copy link
Copy Markdown
Contributor Author

grzuy commented Sep 16, 2021

Allowed.

Still need to figure out how to make the docs for stepped ranges appear given they are a new type of binary operator.

@eldano
Copy link
Copy Markdown
Contributor

eldano commented Sep 16, 2021

Still need to figure out how to make the docs for stepped ranges appear given they are a new type of binary operator.

Nice! Yeah more like a ternary operator. We need to think where the user should click to get the documentation because the operator is splitted in this case. I don't think we'll find a simple solution so maybe we could leave that outside of the scope of this PR. Wdyt?

@grzuy
Copy link
Copy Markdown
Contributor Author

grzuy commented Sep 16, 2021

Still need to figure out how to make the docs for stepped ranges appear given they are a new type of binary operator.

Nice! Yeah more like a ternary operator. We need to think where the user should click to get the documentation because the operator is splitted in this case. I don't think we'll find a simple solution so maybe we could leave that outside of the scope of this PR. Wdyt?

Sounds like a good idea to me 👍

@grzuy grzuy requested a review from eldano September 16, 2021 19:58
@grzuy grzuy merged commit e4264da into master Sep 16, 2021
@grzuy grzuy deleted the elixir-1-12 branch September 16, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants