Skip to content

Prefer Phoenix v1.5 defaults when possible#151

Merged
grzuy merged 7 commits intomasterfrom
phx_defaults
Sep 24, 2021
Merged

Prefer Phoenix v1.5 defaults when possible#151
grzuy merged 7 commits intomasterfrom
phx_defaults

Conversation

@eldano
Copy link
Copy Markdown
Contributor

@eldano eldano commented Sep 23, 2021

Steps taken using phx_new 1.5.12:

  • $ cd ..
  • $ mix phx.new elixir_console --live --no-gettext --no-ecto --no-dashboard
  • Manually chose what to keep and discard

@eldano eldano changed the title Use Phoenix 0.15 defaults Use Phoenix 1.5 defaults Sep 23, 2021
@grzuy grzuy changed the title Use Phoenix 1.5 defaults Prefer Phoenix 1.5 defaults when possible Sep 24, 2021
@grzuy grzuy changed the title Prefer Phoenix 1.5 defaults when possible Prefer Phoenix v1.5 defaults when possible Sep 24, 2021
Comment thread assets/webpack.config.js Outdated
Comment thread lib/elixir_console/application.ex Outdated
Comment thread assets/yarn.lock Outdated
Comment thread assets/yarn.lock Outdated
resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.2.tgz#b5fdc08f1287ea1178628e415e25132b73646c6d"
integrity sha1-tf3AjxKH6hF4Yo5BXiUTK3NkbG0=

signal-exit@^3.0.2:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this and the previous resolution aren't resolved by the same version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forced this to resolve to the same version by deleting these two entries and running yarn install again

@grzuy grzuy merged commit 727675e into master Sep 24, 2021
@grzuy grzuy deleted the phx_defaults branch September 24, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants