Skip to content

Upgrade react-testing-library to 8.0 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2019
Merged

Upgrade react-testing-library to 8.0 #5

merged 4 commits into from
Jul 21, 2019

Conversation

@jihchi
Copy link
Contributor

@jihchi jihchi commented Jul 5, 2019

As title.

@jihchi
Copy link
Contributor Author

jihchi commented Jul 10, 2019

Hi @wyze ,

Could you please take a look when you have time?

wyze
wyze requested changes Jul 13, 2019
View reviewed changes
jihchi
jihchi commented Jul 21, 2019
View reviewed changes
Copy link
Contributor Author

@jihchi jihchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed

wyze
wyze approved these changes Jul 21, 2019
View reviewed changes
Copy link
Owner

@wyze wyze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@wyze wyze merged commit aea4d29 into wyze:master Jul 21, 2019
@jihchi jihchi deleted the upgrade_react_testing_library branch July 21, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyze wyze wyze approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jihchi @wyze