Merged
Conversation
Owner
Author
|
Maybe we need an acknowledgements section? |
Collaborator
|
TODO:
|
rbroc
reviewed
Mar 18, 2025
rdkm89
reviewed
Mar 18, 2025
Collaborator
rdkm89
left a comment
rdkm89
left a comment
There was a problem hiding this comment.
All looks pretty good to me so far! The comments and suggestions are mostly stylistic and designed to improve readability.
There were a few problems with incorrect citations or references to preprints when a published paper exists - those should be resolved.
Owner
Author
KennethEnevoldsen
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a draft of the JOSS submission for review.
@KennethEnevoldsen