Remove pages deleted from pages section of edit counter #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: T232804
Bug: T232804
MusikAnimal
requested changes
Sep 13, 2019
Member
MusikAnimal
left a comment
MusikAnimal
left a comment
There was a problem hiding this comment.
I think this makes sense! Thanks for remembering to update the wikitext template, too.
Everything looks great except with this change we're no longer using the pages-deleted message. We should remove it from en.json and qqq.json (translatewiki will remove it from the other files, and you may not even need to update qqq.json).
Message no longer in use
Message no longer in use
MusikAnimal
approved these changes
Sep 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per reasoning on phab
Bug: T232804