EditCounter: Rework avg/small/larges and compute only against past 5000 edits #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 17.16% 17.04% -0.12%
==========================================
Files 31 31
Lines 3572 3597 +25
==========================================
Hits 613 613
- Misses 2959 2984 +25
Continue to review full report at Codecov.
|
…00 edits Bug: T170103
MusikAnimal
force-pushed
the
avg-large-small-edits
branch
from
0f0ede6 to
0e9098f
Compare
samwilson
approved these changes
Jul 14, 2017
Member
samwilson
left a comment
samwilson
left a comment
There was a problem hiding this comment.
Looks good.
On the tests: I'd normally say it's worth having tests that even just basically test the names of methods (in effect), because they catch things later when refactoring. But not today, let's get this out! :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution to https://phabricator.wikimedia.org/T170103
I did not write tests because the testable functions do nothing more than reference what the Repo returns.