EditCounter: Use review not patrol stats for enwiki

[agoujot]

(Ignore the first five commits, it's just a commit in the wrong branch, its revert, typos in the revert, and merging the main to here. I've cleaned my main branch so this shouldn't happen again.)

Enwiki is the only wiki to use pagetriage, and they barely use patrol.

Therefore, replace the patrol stats by the pagetriage-curation reviewed stats. They have requested this a certain number of times, e.g. T366397, https://www.mediawiki.org/wiki/Topic:Xxhmzabmfwnsuwck, &c.

Which means:

• add reviewed to the list of log types where we want 0 if it's null;
• add a public function that just gives the reviews
• use {% if project.databaseName == enwiki %} in twig

NL said that "Page curation" works as a label and will probably not cause too much confusion, so replace the patrol message by that. (we've already got it translated.)

Bug: T366397

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.95%. Comparing base (4b8eb28) to head (bac26fd).
Report is 72 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Model/Project.php	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #501      +/-   ##
============================================
- Coverage     71.30%   70.95%   -0.36%     
- Complexity     1275     1298      +23     
============================================
  Files            46       46              
  Lines          3792     3901     +109     
============================================
+ Hits           2704     2768      +64     
- Misses         1088     1133      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[agoujot]

Ok, so, after testing and numbers checking:

• corrected reviewed to pagetriage-curation-reviewed
• added actions reviewed-article and reviewed-redirect (ah, nothing like outdated documentation. also, the above is not a superset of these. Possibly an old classification from before it said article/redirect? Anyhow the NPP folks count it separately).
• added patrol-patrol count in that, as the enwp people count it in.(Asked confirmation, just in case.)

[agoujot]

There we go. Should re ready.

[MusikAnimal]

Looking good! I'm happy to merge as-is, but would like to discourage hard-coding database names (though I know we are guilty of doing it in other parts of XTools).

added patrol-patrol count in that, as the enwp people count it in.(Asked confirmation, just in case.)

Looks like we're not including patrol-patrol now? That's good because it would double count reviews, I think. Each initial pagetriage-curation-reviewed* I believe also produces a patrol-patrol log entry.

[MusikAnimal]

Not required but for bonus points: update EditCounterTest::testLogCounts() accordingly :)

[agoujot]

On double-counting: not exactly. Some do, some don't, and anyhow after I asked they told me to split the two, so I did. So right now we've got the two next to each other and they do whatever they want to do with it.

Changed the database name hardcoding.

Also added tests for reviews.

[MusikAnimal]

Thank you! 💯