EditCounter: Rework month and year counts, horizontal bar chart #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Actually, I want to write a test for |
MusikAnimal
force-pushed
the
ec-month-counts
branch
3 times, most recently
from
a2d8ad6 to
a8c4c7b
Compare
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 18.68% 20.41% +1.73%
==========================================
Files 33 33
Lines 3988 4011 +23
==========================================
+ Hits 745 819 +74
+ Misses 3243 3192 -51
Continue to review full report at Codecov.
|
MusikAnimal
force-pushed
the
ec-month-counts
branch
2 times, most recently
from
1a606fb to
ef337c8
Compare
MusikAnimal
changed the title
MusikAnimal
force-pushed
the
ec-month-counts
branch
from
ef337c8 to
9ce6c00
Compare
MusikAnimal
changed the title
MusikAnimal
changed the title
Refactor yearCounts to use monthCounts Only show months from registration date to present getRegistrationDate() added to User
MusikAnimal
force-pushed
the
ec-month-counts
branch
from
9ce6c00 to
9dd19f1
Compare
Member
Author
|
Merging based on Matthew's review. Hope this OK! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show months from registration date to present
getRegistrationDate() added to User
This is a precursor to T171277. The JS to add the actual totals for each month is a little tricky, so I wanted to first get this preliminary work out as a separate PR.