EditCounter: show longest block as the duration, not expiry #98
Conversation
MusikAnimal
force-pushed
the
longest-block-T174012
branch
from
ba15fb8 to
ca0f570
Compare
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 23.28% 23.87% +0.59%
==========================================
Files 30 30
Lines 3569 3602 +33
==========================================
+ Hits 831 860 +29
- Misses 2738 2742 +4
Continue to review full report at Codecov.
|
MusikAnimal
force-pushed
the
longest-block-T174012
branch
3 times, most recently
from
460b108 to
ac7e1b8
Compare
| if ($block['log_action'] === 'block') { | ||
| // This is a new block, so first see if the duration of the last | ||
| // block exceeded our longest duration. -1 duration means indefinite. | ||
| if ($lastBlock[1] > $this->longestBlockSeconds || $lastBlock[1] === -1) { |
There was a problem hiding this comment.
The first time this loop executes, it's going to throw an undefined variable notice about $lastBlock[1]. Shouldn't $lastBlock = [$timestamp, $duration]; happen earlier?
There was a problem hiding this comment.
We don't want to set the timestamp and duration yet, but you're right the initial declaration should be like $lastBlock = [null, null]
Loop through the block log to get the amount of time the user was blocked. Bug: https://phabricator.wikimedia.org/T174012
MusikAnimal
force-pushed
the
longest-block-T174012
branch
from
ac7e1b8 to
82e2f1f
Compare
|
Code review concerns addressed; going to go ahead and merge so I can get this and T177172 deployed, hope that's OK |
Loop through the block log to get the amount of time the user
was blocked.
Bug: https://phabricator.wikimedia.org/T174012