Conversation
ex10ded
force-pushed
the
add_l1_key_generation
branch
from
7a981b4 to
ed68532
Compare
alexex10
approved these changes
Jul 31, 2024
Contributor
alexex10
left a comment
alexex10
left a comment
There was a problem hiding this comment.
Pls see some minor comments
|
|
||
| payload = get_onboarding_payload( | ||
| l1_account, | ||
| time=datetime.datetime( |
Contributor
There was a problem hiding this comment.
[nit] We can also do it this way (or with strptime):
datetime.fromisoformat('2024-07-30T16:01:02+00:00')
| ), | ||
| ).to_json() | ||
|
|
||
| assert ( |
Contributor
There was a problem hiding this comment.
[nit] It might be better to do it this way:
from hamcrest import assert_that, equal_to
assert_that(
payload,
equal_to(
{
# ....
}
),
)
| action: str | ||
|
|
||
| def __post_init__(self): | ||
| self.time_string = self.time.astimezone(UTC).strftime("%Y-%m-%dT%H:%M:%SZ") |
Contributor
There was a problem hiding this comment.
It is better to add this field to class definition
| } | ||
| types = { | ||
| "EIP712Domain": [ | ||
| {"name": "name", "type": "string"}, |
Contributor
There was a problem hiding this comment.
Just curious if we need to add chainId?
alexex10
reviewed
Jul 31, 2024
| action: str | ||
|
|
||
| def __post_init__(self): | ||
| self.time_string = self.time.astimezone(timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ") |
Contributor
There was a problem hiding this comment.
It is better to add this field to class definition
0xsumatt
pushed a commit
to 0xsumatt/x10_python_sdk
that referenced
this pull request
Mar 31, 2025
add onboarding payload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes