Conversation
alexex10
commented
Aug 1, 2024
Contributor
Author
There was a problem hiding this comment.
I faced some problems with testing this logic as it requires network requests to build tx (chain RPC call), will think if there is a way to do it locally.
alexex10
commented
Aug 1, 2024
| ), | ||
| eth_private_key, | ||
| ) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
It might make sense to eth_private_key = None, but need to do a memory dump and check when it will be collected by gc.
Contributor
There was a problem hiding this comment.
lets see if we can harmonise between eth_account and web3 methods of signing / private key management - will do an investigation.
Contributor
Author
There was a problem hiding this comment.
hm, I like 100% sure it is possible 'cause web3 uses eth_account for this. but I think we should NOT "cache" or store L1 private key in any long-lived variable inside SDK.
ex10ded
approved these changes
Aug 4, 2024
0xsumatt
pushed a commit
to 0xsumatt/x10_python_sdk
that referenced
this pull request
Mar 31, 2025
…laim Slow withdrawals (reclaim)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
account.withdrawal_slow_reclaimmethodUsage example: