Add simple liquidity bot #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ex10ded
force-pushed
the
add_simple_liquidity_bot
branch
from
233be0c to
5608c38
Compare
alexex10
reviewed
Jul 2, 2025
| chain_rpc_url="https://rpc.sepolia.org", | ||
| api_base_url="https://api.starknet.sepolia.extended.exchange/api/v1", | ||
| stream_url="wss://api.starknet.sepolia.extended.exchange/stream.extended.exchange/v1", | ||
| stream_url="wss://starknet.sepolia.extended.exchange/stream.extended.exchange/v1", |
Contributor
There was a problem hiding this comment.
this is for UI, pls revert
| target_order_amount_usd = Decimal("50") | ||
| market = available_markets["BTC-USD"] | ||
| await root_trading_client.mass_cancel(markets=[market.name]) | ||
| buy_orders_infoz: List[Tuple[str, Decimal] | None] = [None, None, None] |
Contributor
There was a problem hiding this comment.
why can't we reuse OrderBookEntry?
| self.init_orderbook(event.data) | ||
| elif event.type == StreamDataType.DELTA.value: | ||
| self.update_orderbook(event.data) | ||
| while True: |
| try: | ||
| return await self.__receive() | ||
| except websockets.ConnectionClosed: | ||
| raise StopAsyncIteration from None |
Contributor
There was a problem hiding this comment.
from None -- why we can't use correct cause?
| """ | ||
|
|
||
| url = self.__get_url("/orderbooks/<market?>", market=market_name) | ||
| url = self.__get_url("/orderbooks/<market?>" + (f"?depth={depth}" if depth else ""), market=market_name) |
Contributor
There was a problem hiding this comment.
pls check test_generate_valid_url_from_template you can do
query={ "depth": depth }
if will be removed if it is None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.