Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Conversation

@newky2k
Copy link
Contributor

@newky2k newky2k commented Jun 27, 2019

Fixes #802

Description of Change

Describe your changes here.

Bugs Fixed

  • Related to issue #

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

List all API changes here (or just put None), example:

Added:

  • string Class.Property { get; set; }
  • void Class.Method();

Changed:

  • object Cell.OldPropertyName => object Cell.NewPropertyName

If there is an entirely new API, then you can use a more verbose style:

public static class NewClass {
    public static int SomeProperty { get; set; }
    public static void SomeMethod(string value);
}

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@ghost
Copy link

ghost commented Jun 27, 2019

Docs Build status updates of commit c3c4d8a:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Geolocation/GeolocationRequest.shared.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link

ghost commented Jun 27, 2019

Docs Build status updates of commit f26b211:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Geolocation/GeolocationRequest.shared.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@newky2k newky2k added the awaiting-review This PR needs to have a set of eyes on it label Jun 27, 2019
@jamesmontemagno jamesmontemagno merged commit a3beded into master Jun 27, 2019
@jamesmontemagno jamesmontemagno deleted the dh_GeolocationAccuracy branch June 27, 2019 21:34
Mrnikbobjeff pushed a commit to Mrnikbobjeff/Essentials that referenced this pull request Aug 28, 2019
nickrandolph pushed a commit to builttoroam/Essentials that referenced this pull request Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

awaiting-review This PR needs to have a set of eyes on it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GeolocationAccuracy.High uses POWER_HI on Android, while comment says it uses POWER_MED

4 participants