This repository was archived by the owner on Dec 13, 2024. It is now read-only.
add tvOS native AOT sample #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfbjarne
suggested changes
Aug 20, 2024
Comment on lines
24
to
38
| <!-- <ItemGroup> | ||
| <ImageAsset Include="Assets.xcassets\LaunchImages.launchimage\Contents.json" /> | ||
| <ImageAsset Include="Assets.xcassets\Contents.json" /> | ||
| <ImageAsset Include="Assets.xcassets\LaunchImages.launchimage\LaunchImage.png" /> | ||
| <ImageAsset Include="Assets.xcassets\App Icon & Top Shelf Image.brandassets\App Icon - Large.imagestack\Back.imagestacklayer\Content.imageset\Contents.json" /> | ||
| <ImageAsset Include="Assets.xcassets\App Icon & Top Shelf Image.brandassets\App Icon - Large.imagestack\Back.imagestacklayer\Content.imageset\xamarin-large-back.png" /> | ||
| <ImageAsset Include="Assets.xcassets\App Icon & Top Shelf Image.brandassets\App Icon - Large.imagestack\Back.imagestacklayer\Contents.json" /> | ||
| <ImageAsset Include="Assets.xcassets\App Icon & Top Shelf Image.brandassets\App Icon - Large.imagestack\Contents.json" /> | ||
| <ImageAsset Include="Assets.xcassets\App Icon & Top Shelf Image.brandassets\App Icon - Large.imagestack\Front.imagestacklayer\Content.imageset\Contents.json" /> | ||
| <ImageAsset Include="Assets.xcassets\App Icon & Top Shelf Image.brandassets\App Icon - Large.imagestack\Front.imagestacklayer\Content.imageset\xamarin-large-front.png" /> | ||
| <ImageAsset Include="Assets.xcassets\App Icon & Top Shelf Image.brandassets\App Icon - Large.imagestack\Front.imagestacklayer\Contents.json" /> | ||
| <ImageAsset Include="Assets.xcassets\App Icon & Top Shelf Image.brandassets\App Icon - Large.imagestack\Middle.imagestacklayer\Content.imageset\Contents.json" /> | ||
| <ImageAsset Include="Assets.xcassets\App Icon & Top Shelf Image.brandassets\App Icon - Large.imagestack\Middle.imagestacklayer\Contents.json" /> | ||
| <ImageAsset Include="Assets.xcassets\App Icon & Top Shelf Image.brandassets\App Icon - Small.imagestack\Back.imagestacklayer\Content.imageset\Contents.json" /> | ||
| <ImageAsset Include="Assets.xcassets\App Icon & Top Shelf Image.brandassets\App Icon - Small.imagestack\Back.imagestacklayer\Content.imageset\xamarin-back.png" /> |
Member
There was a problem hiding this comment.
I think the publishing failures are due to missing resources (which can admittedly be hard to get right).
The error message complains about these resources, which I don't see in the csproj:
"Missing Image Asset. Your app is missing the Home Screen Icon asset in 'Payload/tvOSNativeAOTApp.app'.
"Missing Image Asset. Your app is missing the App Store Icon asset in 'Payload/tvOSNativeAOTApp.app'.
"Missing Image Asset. Your app is missing the Top Shelf Image Wide asset in 'Payload/tvOSNativeAOTApp.app'.
Can you try adding these resource and see if that submits successfully?
Contributor
Author
There was a problem hiding this comment.
after doing a bit more investigating using assetutil in xcrun, the Assets.car was not being correctly created in the bundle but making a few modifications to the entitlements and keys in the info.plist seems to have resolved this now
successful verification and upload to App Store: https://gist.github.com/haritha-mohan/cc050d34cd23fba0882d0693b5b0d5db
rolfbjarne
approved these changes
Aug 22, 2024
dalexsoto
approved these changes
Aug 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update: successfully submits to App Store now
gist: https://gist.github.com/haritha-mohan/cc050d34cd23fba0882d0693b5b0d5db
sample builds fine, but running into issues at the Validation step local gist for context: https://gist.github.com/haritha-mohan/2ffba92bc62c59ec978ca0f1a4a2e61b
assets in tvOS apps seems to be a troublesome area for many..this latest attempt at trying to resolve this included creating a tvOS app via Xcode 16 and just copying over the assets folder to our sample here to see if that would help but alas the error remains..
based on research online, it seems that that oftentimes the actual solution might not have anything to do with the assets themselves but rather a property in the Info.plist or something else along those lines...
refs:
https://forums.developer.apple.com/forums/thread/92000
https://stackoverflow.com/questions/74145890/xcode-14-asset-validation-failed-missing-app-icon
dotnet/macios#18991
note: the only thing I haven't tried listed in the links is moving the itmstransporter..want to make sure we've attempted any other low hanging solutions before going into the deep end 😅