Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[UWP] Animate ListView.ScrollTo #2557

Merged
merged 1 commit into from
May 15, 2018
Merged

[UWP] Animate ListView.ScrollTo #2557

merged 1 commit into from
May 15, 2018

Conversation

@paymicro
Copy link
Contributor

@paymicro paymicro commented Apr 27, 2018 •
edited by samhouts
Loading

Description of Change

added animate code to ListView.ScrollTo in UWP
Screencast: https://www.screencast.com/t/liuXQZ9arEh

Bugs Fixed

Fixes #2048

API Changes

None

Behavioral Changes

If parameter shouldAnimate is true, then scrolling should be animated =)

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@paymicro paymicro changed the base branch from master to 3.0.0 April 27, 2018 14:01
@samhouts samhouts changed the title [UWP] Animate ListView.ScrollTo (#2486) [UWP] Animate ListView.ScrollTo Apr 27, 2018
@rmarinho rmarinho requested review from jassmith and rmarinho May 9, 2018 09:06
@rmarinho rmarinho merged commit 2d55423 into xamarin:3.0.0 May 15, 2018
@paymicro paymicro deleted the fix-gh2048-ScrollTo_animated branch May 16, 2018 05:52
@samhouts samhouts added this to the 3.0.0 milestone Jun 1, 2018
@samhouts samhouts added the p/UWP label Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jassmith jassmith Awaiting requested review from jassmith

1 more reviewer

@rmarinho rmarinho rmarinho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p/UWP t/bug 🐛

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@paymicro @rmarinho @samhouts