This repository has been archived by the owner on May 1, 2024. It is now read-only.
[C] detach Behaviors and Triggers on VE finalization #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -163,6 +163,14 @@ internal bool GetIsBound(BindableProperty targetProperty) | |||
| return bpcontext != null && bpcontext.Binding != null; | |||
| } | |||
|
|
|||
| internal bool GetIsDefault(BindableProperty targetProperty) | |||
There was a problem hiding this comment.
this is to avoid calling the defaultValueCreator is the BP is not used
|
+1 if this is a better fix. |
samhouts
approved these changes
Nov 21, 2016
4 tasks
|
See #701 for related crash. |
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* GH-23: Added Tizen backend (#555) * Adding the initial work to get Tizen started. #23 * Adding the initial work to get Tizen started. #23 * Use the overloads properly. * Use the overloads properly. * Tizen needs to have a background explicitly set * Added the Vibration API * Added the Vibration API * Refactoring a little bit * Refactoring a little bit * Added the Browser API and some basic permissions checking * Added the Browser API and some basic permissions checking * Added the Battery API * Added the Battery API * Added the Acceleromerter API * Added the Acceleromerter API * Added the Filesystem API * Added the Filesystem API * Update Accelerometer Initialize using GetDefaultSensor * Update Accelerometer Initialize using GetDefaultSensor * Added the Gyroscope API * Added the Gyroscope API * Added the Magnetometer API * Added the Magnetometer API * Added the Compass API * Added the Compass API * Added the Connectivity API * Added the Connectivity API * Added the Flashlight API * Added the Flashlight API * Added the SecureStorage API * Added the SecureStorage API * Added the Vibration API * Added the Vibration API * Fixed build break * Fixed build break * Added the OrientationSensor API * Fixed build break * Initialized Maps/Launcher for Tizen * Added the Permissions API * Added the Geolocation API * Added the Geocoding API * Fixed build break * Initialize Barometer API * Added the Barometer API * Added the TextToSpeech API * Added the Launcher APIs * Fixed bugs * Update Location property name * Update several modules - Update AppInfo, Browser, Clipboard, Compass, Connectivity, DisplayInfo, DeviceInfo, Geocoding, TextToSpeech modules - Change module name DataTrasfer to Share, Maps to Map - Integrated module Power to Battery, ScreenLock to DeviceDisplay * Throw PlatformNotSupportedException for Tizen * Change the exception for the power saver feature * Add tizen privileges * Add FileBase * Add ShareFileRequest * Change enum for Browser * Change parameter for Permissions * Add SensorSpeedExtensions * Add Launcher for OpenFileRequest * Fix .csproj for VS2019 * Fix sample for watch * Fix Geolocation speed * Fix TextToSpeech ptich * Fixed missing using System; This was needed for the Math calls * Add Support for ⌚OS and 📺OS (#827) * Add Support for watchOS and tvOS * Fix up exception from shared netstandard code to figure out what to send. * Update Battery.ios.watchos.cs * Integrate Tizen into the netstandard not supported area. * [Tizen] Fix reference for avoid duplication (#850) * Fix reference to avoid version collision * Remove Vector3 reference on Tizen * Fix iPad not show share sheet (#873) Need to specify bottom center of the screen. * Added the Main Thread helpers from Xamarin.Forms (#849) * Added Invoke methods from Xamarin.Forms * Updated to use Essentials approach to calling the MainThread * Updated the docs with the new MainThread methods * Make overload more readable The old code was I think incorrect in that the `funcTask()` was never awaited or returned as a task. This is the same code as the overload with the generic type parameter, but without the type param. * Updated to use UrlEncode in GetMailToUrl (#848) * Updated to use UrlEncode in GetMailToUrl Fixes #843 * Added missing using * Fixed Using order and spacings * Use WebUtility.UrlEncode on placemark extensions * Added volatile to MainThread.Android (#877) Fixes #838 * Add Launcher.TryOpenAsync (#839) * Add Launcher.TryOpenAsync * Added ConfigureAwait(false) * Removed unnecessary async * Updated launcher docs * Updated the docs * Added Launch Tests * Add aka.ms for release notes (#883) * Remove experimental flags & fix launcher teasts (#887)
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* GH-23: Added Tizen backend (#555) * Adding the initial work to get Tizen started. #23 * Adding the initial work to get Tizen started. #23 * Use the overloads properly. * Use the overloads properly. * Tizen needs to have a background explicitly set * Added the Vibration API * Added the Vibration API * Refactoring a little bit * Refactoring a little bit * Added the Browser API and some basic permissions checking * Added the Browser API and some basic permissions checking * Added the Battery API * Added the Battery API * Added the Acceleromerter API * Added the Acceleromerter API * Added the Filesystem API * Added the Filesystem API * Update Accelerometer Initialize using GetDefaultSensor * Update Accelerometer Initialize using GetDefaultSensor * Added the Gyroscope API * Added the Gyroscope API * Added the Magnetometer API * Added the Magnetometer API * Added the Compass API * Added the Compass API * Added the Connectivity API * Added the Connectivity API * Added the Flashlight API * Added the Flashlight API * Added the SecureStorage API * Added the SecureStorage API * Added the Vibration API * Added the Vibration API * Fixed build break * Fixed build break * Added the OrientationSensor API * Fixed build break * Initialized Maps/Launcher for Tizen * Added the Permissions API * Added the Geolocation API * Added the Geocoding API * Fixed build break * Initialize Barometer API * Added the Barometer API * Added the TextToSpeech API * Added the Launcher APIs * Fixed bugs * Update Location property name * Update several modules - Update AppInfo, Browser, Clipboard, Compass, Connectivity, DisplayInfo, DeviceInfo, Geocoding, TextToSpeech modules - Change module name DataTrasfer to Share, Maps to Map - Integrated module Power to Battery, ScreenLock to DeviceDisplay * Throw PlatformNotSupportedException for Tizen * Change the exception for the power saver feature * Add tizen privileges * Add FileBase * Add ShareFileRequest * Change enum for Browser * Change parameter for Permissions * Add SensorSpeedExtensions * Add Launcher for OpenFileRequest * Fix .csproj for VS2019 * Fix sample for watch * Fix Geolocation speed * Fix TextToSpeech ptich * Fixed missing using System; This was needed for the Math calls * Add Support for ⌚OS and 📺OS (#827) * Add Support for watchOS and tvOS * Fix up exception from shared netstandard code to figure out what to send. * Update Battery.ios.watchos.cs * Integrate Tizen into the netstandard not supported area. * [Tizen] Fix reference for avoid duplication (#850) * Fix reference to avoid version collision * Remove Vector3 reference on Tizen * Fix iPad not show share sheet (#873) Need to specify bottom center of the screen. * Added the Main Thread helpers from Xamarin.Forms (#849) * Added Invoke methods from Xamarin.Forms * Updated to use Essentials approach to calling the MainThread * Updated the docs with the new MainThread methods * Make overload more readable The old code was I think incorrect in that the `funcTask()` was never awaited or returned as a task. This is the same code as the overload with the generic type parameter, but without the type param. * Updated to use UrlEncode in GetMailToUrl (#848) * Updated to use UrlEncode in GetMailToUrl Fixes #843 * Added missing using * Fixed Using order and spacings * Use WebUtility.UrlEncode on placemark extensions * Added volatile to MainThread.Android (#877) Fixes #838 * Add Launcher.TryOpenAsync (#839) * Add Launcher.TryOpenAsync * Added ConfigureAwait(false) * Removed unnecessary async * Updated launcher docs * Updated the docs * Added Launch Tests * Add aka.ms for release notes (#883) * Remove experimental flags & fix launcher teasts (#887)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Detach Triggers and Behaviors on VE finalizer, because they're not IDisposable...
Bugs Fixed
PR Checklist