New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] detach Behaviors and Triggers on VE finalization #555

Merged
merged 2 commits into from Dec 6, 2016

Conversation

Projects
None yet
5 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Nov 21, 2016

Description of Change

Detach Triggers and Behaviors on VE finalizer, because they're not IDisposable...

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@@ -163,6 +163,14 @@ internal bool GetIsBound(BindableProperty targetProperty)
return bpcontext != null && bpcontext.Binding != null;
}
internal bool GetIsDefault(BindableProperty targetProperty)

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Nov 21, 2016

Member

this is to avoid calling the defaultValueCreator is the BP is not used

@StephaneDelcroix

StephaneDelcroix Nov 21, 2016

Member

this is to avoid calling the defaultValueCreator is the BP is not used

@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89

adrianknight89 Nov 21, 2016

Contributor

+1 if this is a better fix.

Contributor

adrianknight89 commented Nov 21, 2016

+1 if this is a better fix.

@rmarinho rmarinho merged commit 20e2e12 into master Dec 6, 2016

1 check passed

Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 9 :: Windows Debug : Tests passed: 3586, ignored: 10
Details

@StephaneDelcroix StephaneDelcroix deleted the fix-44074 branch Jan 31, 2017

@samhouts samhouts referenced this pull request Mar 22, 2017

Closed

Clear attached properties when views are being disposed #553

4 of 4 tasks complete
@samhouts

This comment has been minimized.

Show comment
Hide comment
@samhouts

samhouts Mar 22, 2017

Member

See #701 for related crash.

Member

samhouts commented Mar 22, 2017

See #701 for related crash.

@samhouts samhouts added D15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment