This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Core] Account for TranslationX/Y when laying out children into bounding region #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit efba29e.
|
translationX and Y properties are never handled in Core, but in the different platforms (VisualElementTracker) that's probably were you should look at. trying to figure out why the view isn't displayed with the correct translationX. |
|
The fix for this issue needs to be done in the renderers. Moving things here does a pre layout transform instead of a post layout transform. |
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* Use SharedPreferences.Editor.Apply when editing to force disk write to be asynchronous (#637) * GH-182 Color/Point/Rect/Size Extension Converters (#651) * Add extension helpers for iOS and Android * Add UWP colors and adjsut android colors. * Add UWP Point/Rect/Size * Rename and optimize! * Add tests and color helpers! * Fix unit test and add WithAlpha * Cleanup iOS as it stores it from 0-1 * Tests are all green! * Add generate-docs cmd :) * Add docs config to all :) * Additional clenaup for docs * Added some docs * Updated the mdoc target and regenerated the docs * Allow for code reuse on macOS (#665) Even though macOS is not yet officially supported, it is nice to reuse this code. macOS is exactly the same, except for this single property not supported. * GH-196 Browser Customization (#646) * Implemented GH-196 * Apply suggestions from code review: Naming Renamed incorrectly spelled variables Co-Authored-By: Mrnikbobjeff <schillinik@yahoo.de> * Implemented GH-196 * Browser update work as requested. Using System.Drawing.Color now * Adopted more review changes. Type forwarded. * Review changes * Made equals operator null safe, removed constructor * Add documentation and simplify the API! * Update viewmodel * Back to 7.2 * GH-676 Require To Check GPS Location is Fake Or Not In GeoLocation (#677) * Added bool IsFromMockProvider in Location class * Checkin * csproj original * Revert "csproj original" This reverts commit 6302b95782006288862f0ce11100c81936baa7fb. * Revert "Checkin" This reverts commit 0881e4f12c36caecd08b3b9bb8757d8bd1025502. * Revert "Added bool IsFromMockProvider in Location class" This reverts commit e56d9406cf0a92d24b04607afe81aef23aca696c. * Revert the Xamarin.Essentials.csproj and Samples.Android.csproj to original; Adjust the property IsFromMockProvider in Location.shared and LocationExetensions. * Edited sample to show if the location is from moking provider. * Update docs * Fixes #694 (#699) * Update the mdoc to use the new minimum for VS2019 * GH-126: Finish Shake Detector API (#693) * Update CONTRIBUTING.md (#692) * GH-126 Detect Shake API (#666) * Added shaken support * name vhange * check-in * doc update * Implements the Shake API inside Accelerometer Class; Change sample to AccelorometerViewModel * Fix the sample project * Update the docs * Added Queue mechanism based off seismic with tests as well. Something is not right yet with calulating isaccelerating. * Finalize shake detection!!! * Re-generated the docs. * Fix the VM after merge * GH-704 Handle duplicate item in keychain (#705) * Update CONTRIBUTING.md (#692) * #704 if we get a duplicate item try to remove and then re-add if possible. * Add all possible combinations for coords to km or mile (#721) * Add all possible combinations for coords to km or mile * Update UnitConverters_Tests.cs * Use more explicit job definitions * Update UnitConverters_Tests.cs * GH-698 Set longer delay on connectivity changes - Android (#700) * Update CONTRIBUTING.md (#692) * Fixes #698 * Use original string instead of uri (#716) * GH-643: Add Android P targeting and support 28 support (#669) * Update PULL_REQUEST_TEMPLATE.md * Fixes #643 to add android P targeting and support 28 support * Add suppresses for Android P * Cleanup SDKs based on @Redth * Update more nugets * More optimizations for Retargeting * Refactor HasApiLevelN and updated support to 28.0.0.1 * Update manifest and key :) * Update the device tests certificates * Make sure to run the checks always * Updating the certs again to see if CI notices this time... * Change order to reflect enum (#735) * Lock keystore on Android for cipher (#734) * Add locks around android keystore. * move convert out of lock * GH-130 & GH-129: Android support for safe shareable file URI’s (#416) * Android: Support for safe shareable file URI’s On later versions of Android, you have to wrap streams of data you want to share outside your app (between apps) in a stream through a content provider. Android Support providers a general use FileProvider we can use for this. This commit basically adds support for getting all the right AndroidManifest declarations for the custom file provider based on the android support provider, so that we expose an internal method which gets a URI safe for sharing outside of the app. * Fix absolute type naming * Add a user interaction test for File Provider * Fix vibration code the ifdef meant an empty `else { }` statement with no `if { }` for platforms < 26. This fixes that. * Reorder using statements * Fix test attribute * Get provider authority properly * Added external storage permission * Change file provider path This is md5(“xamarin_essentials”) * Copy file into temp folder instead of file We keep the filename the same this way but use a GUID for a temp sub-folder to ensure a unique path. * Resgen * Permissions may need to be checked to control functionality * The Android FileProvider now can detect permissions - internal / external storage can be controlled - KitKat+ does not require the permissions - corrected the FileProvider resource xml * Added support for email attachments - support for a string path and native file types * Added attachments to the sample app * Updated the docs with the new types * Some fixes for iOS * Fix the mdoc target * regen docs * remove the obsolete armeabi ABI * Reworked the file logic to try and use public folders first - if the file is already exposed, then just use it directly - if the file is private, copy to an exposed location first - exposing the internal and external caches and the public/external files * Be more specific with the external storage permission name * Added some more depth to the comments here * Unnecessary else * Added base file info class * EmailAttachment now derives from FileBase * Added File Sharing * Keep track of IStorageFile internally * Prefer internal IStorageFile in UWP * Use attachment name properly in UWP * Add ctor to create from existing FileBase This will let us use UWP to create a new instance of something derived from FileBase with another instance of something else derived from FileBase, all while keeping track of the same `IStorageFile` instance. So we can conceivably do something like: ```csharp var mediaFile = await MediaPicker.PickPhotoAsync(); var attachment = new EmailAttachment(mediaFile); ``` * Add ctors for FileBase * Add ctors for ShareFileRequest * We can't use N on pre-N platforms * Updated the docs * Update some docs. * Bump * Gate Email/Share files with feature flags * Add sample for ShareFileRequest * Added test for share method in netstandard * [WIP] Adding the Device Tests to the yaml (#737) * Add the device tests to the yaml * Select the latest version of xamarin/xcode * Specify the iPhone simulator in the yaml * Install the Android emulator * Fix the shared test * try to resolve build issue with missing nuget * Fix docs * Fix ref * Trim . off start of extension for getting mimetype * Don't add empty strings on UWP to email (#738) * Cleanup UWP a bit
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* Use SharedPreferences.Editor.Apply when editing to force disk write to be asynchronous (#637) * GH-182 Color/Point/Rect/Size Extension Converters (#651) * Add extension helpers for iOS and Android * Add UWP colors and adjsut android colors. * Add UWP Point/Rect/Size * Rename and optimize! * Add tests and color helpers! * Fix unit test and add WithAlpha * Cleanup iOS as it stores it from 0-1 * Tests are all green! * Add generate-docs cmd :) * Add docs config to all :) * Additional clenaup for docs * Added some docs * Updated the mdoc target and regenerated the docs * Allow for code reuse on macOS (#665) Even though macOS is not yet officially supported, it is nice to reuse this code. macOS is exactly the same, except for this single property not supported. * GH-196 Browser Customization (#646) * Implemented GH-196 * Apply suggestions from code review: Naming Renamed incorrectly spelled variables Co-Authored-By: Mrnikbobjeff <schillinik@yahoo.de> * Implemented GH-196 * Browser update work as requested. Using System.Drawing.Color now * Adopted more review changes. Type forwarded. * Review changes * Made equals operator null safe, removed constructor * Add documentation and simplify the API! * Update viewmodel * Back to 7.2 * GH-676 Require To Check GPS Location is Fake Or Not In GeoLocation (#677) * Added bool IsFromMockProvider in Location class * Checkin * csproj original * Revert "csproj original" This reverts commit 6302b95782006288862f0ce11100c81936baa7fb. * Revert "Checkin" This reverts commit 0881e4f12c36caecd08b3b9bb8757d8bd1025502. * Revert "Added bool IsFromMockProvider in Location class" This reverts commit e56d9406cf0a92d24b04607afe81aef23aca696c. * Revert the Xamarin.Essentials.csproj and Samples.Android.csproj to original; Adjust the property IsFromMockProvider in Location.shared and LocationExetensions. * Edited sample to show if the location is from moking provider. * Update docs * Fixes #694 (#699) * Update the mdoc to use the new minimum for VS2019 * GH-126: Finish Shake Detector API (#693) * Update CONTRIBUTING.md (#692) * GH-126 Detect Shake API (#666) * Added shaken support * name vhange * check-in * doc update * Implements the Shake API inside Accelerometer Class; Change sample to AccelorometerViewModel * Fix the sample project * Update the docs * Added Queue mechanism based off seismic with tests as well. Something is not right yet with calulating isaccelerating. * Finalize shake detection!!! * Re-generated the docs. * Fix the VM after merge * GH-704 Handle duplicate item in keychain (#705) * Update CONTRIBUTING.md (#692) * #704 if we get a duplicate item try to remove and then re-add if possible. * Initial commit Clipboard Change * Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support. * Initial commit Clipboard Change * Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support. * Naming fix * UI improvements * Docs update * docs update part 2 * docs tool breaking fix * reverted change to csproj
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In the below bug description, the user is having an issue when a
ViewCellis scrolled off the screen, itsViewlosesTranslationX. The change I made fixes this issue; however, I'm not 100% sure about the change as the layouting system is still a black box to me.The sample code should demonstrate the solution. You can also give
PosXa starting value so the cells are initially laid out with a non-zeroTranslationX.Note that this is a change in Core, and I do not know how to unit test it.
Bugs Fixed
PR Checklist