New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Account for TranslationX/Y when laying out children into bounding region #637

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@adrianknight89
Contributor

adrianknight89 commented Dec 12, 2016

Description of Change

In the below bug description, the user is having an issue when a ViewCell is scrolled off the screen, its View loses TranslationX. The change I made fixes this issue; however, I'm not 100% sure about the change as the layouting system is still a black box to me.

The sample code should demonstrate the solution. You can also give PosX a starting value so the cells are initially laid out with a non-zero TranslationX.

Note that this is a change in Core, and I do not know how to unit test it.

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix Dec 13, 2016

Member

translationX and Y properties are never handled in Core, but in the different platforms (VisualElementTracker)

that's probably were you should look at. trying to figure out why the view isn't displayed with the correct translationX.

Member

StephaneDelcroix commented Dec 13, 2016

translationX and Y properties are never handled in Core, but in the different platforms (VisualElementTracker)

that's probably were you should look at. trying to figure out why the view isn't displayed with the correct translationX.

@jassmith

This comment has been minimized.

Show comment
Hide comment
@jassmith

jassmith Dec 13, 2016

Member

The fix for this issue needs to be done in the renderers. Moving things here does a pre layout transform instead of a post layout transform.

Member

jassmith commented Dec 13, 2016

The fix for this issue needs to be done in the renderers. Moving things here does a pre layout transform instead of a post layout transform.

@jassmith jassmith closed this Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment