New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Fixed Tab NSImage crash in TabbedPageRenderer #705

Merged
merged 3 commits into from Jan 23, 2017

Conversation

Projects
None yet
4 participants
@MarkoBL
Contributor

MarkoBL commented Jan 23, 2017

Description of Change

GetTabViewItemIcon uses NSImage.ImageNamed, which supports only named images or images in the root directory of the bundle. This PR adds support for images in a subdirectory. It also prevents the app from crashing, if the image is not found.

Bugs Fixed

None

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Jan 23, 2017

Hi @MarkoBL, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

dnfclas commented Jan 23, 2017

Hi @MarkoBL, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Jan 23, 2017

@MarkoBL, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

dnfclas commented Jan 23, 2017

@MarkoBL, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@dnfclas dnfclas added the cla-signed label Jan 23, 2017

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Jan 23, 2017

Member

Thanks :)

Member

rmarinho commented Jan 23, 2017

Thanks :)

@rmarinho rmarinho merged commit 60e791d into xamarin:macOS Jan 23, 2017

2 of 3 checks passed

iOS9-UITests-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3697, ignored: 10
Details

rmarinho added a commit that referenced this pull request Jan 23, 2017

[macOS] Fixed Tab NSImage crash in TabbedPageRenderer (#705)
* [macOS] Fixed Tab NSImage crash in TabbedPageRenderer

* Coding Style

* Coding Style

rmarinho added a commit that referenced this pull request Jan 26, 2017

MacOS (#650)
* [MacOS] Add SwitchRenderer

* [MacOS] Add TimePickerRenderer

* [MacOS] Cleanup TimePcikerRender

* [MacOS] Add WebViewRenderer

* [MacOS] Add Javascript evaluate to webview

* [MacOS] Fix build error on WebViewRenderer

* [MacOS] Add Base and TextCell renderers

* [MacOS] Start on ListViewRenderer

* [MacOS] Cleanup

* [MacOS] Vertical center text on default NSTextField

* [MacOS] Center NSTextField vertically

* [MacOS] Add ImageCellRenderer

* [MacOS] Add SwitchCellRenderer

* [MacOS] Add SwitchCellRenderer

* [iOS] Allow to set background color on other CellRenderers

* [MacOS] Fix selection mode on ListView

* [MacOS] Set background on Entry of entry cell

* [MacOS] Fix casting bug on CellRenderer

* [MacOS] Other fix on CellRenderer background

* [MacOS] Add ViewCellRenderer

* [MacOS] Fixes and cleanup on cells

* [MacOS] Add NSScrollView so NSTableView can scroll

* [MacOS] Add HeaderView to ListView

* [MacOS] Cleanup

* [Controls] Add Header support to ListView

* [MacOS] NSView reuse on NSTableView

* [MacOS] Some fix on layour order

* [MacOS] Add CarouselPageRenderer

* [MacOS] Implement EventTracker on PageRenderer

* [MacOS] Cleanup CarouselPageRenderer

* [MacOS] Add MasterDetailPage renderer

* [MacOS] MDP renderer don't allow drag of splitter

* [MacOS] Add TabbedPage renderer

* [MacOS] Initial sketch of NavigationPageRenderer

* [MacOS] Send disappearing of CurrentPage on Dispose on NavigationPageRenderer

* [MacOS] Add Gallery page for Mac

* [MacOS] Add MacOSExpressionSearch

* [MacOS] Fix ColorExtension

* [MacOS] Fix MDP renderer layout

* [MacOS] Implement native selection on ListViewRenderer

* [MacOS] Deselect a item on NSTableView

* [MacOS] Remove previous SplitViewItems

* [MacOS] Fix navigationpage height

* [MacOS] Add toolbar for NavigationPageRenderer

* [MacOS] Don't remove selection for now (crashing)

* [MacOS] Refactor page and back button title on NavigationPageRenderer

* [MacOS] Fix bug when native navigate back

* [MacOS] Hide layer when transition

* [MacOS] ListviewRenderer fix BbackgroundColor

* [MacOS] Fix background on ScrollViewRenderer

* [MacOS] Fix header measure on ListViewRenderer

* [MacOS] Add Mac twitter demo

* [Controls] Spaces for easy reading

* [MacOS] More xaml cleanup

* [Core] Add Mac as aTargetPlatform

* [MacOS] Add alerts and actionsheets

* [MacOS] Add GestureRecognizers

* [MacOS] Fix Layout issues when adding children, enable transformations

* [MacOS] Fix title on tab item, move to tabbed navigation based on segmented control

* [MacOS] Hide toolbar when not needed, this allows to work with tabbed page, cleanup

* [MacOS] Add NativeBindings and NativeViewWrapper

* [MacOS] Fix AssemblyInfo

* [MacOS] FIX NRE on SetBackgroundColor BoxView

* [MacOS] Fix NavigationPageRenderer

* [MacOS] Fix build

* [MacOS] Also update page when it resizes

* [MacOS] Add LayoutRenderer for handle items position when the bounds change.

* [MacOS] Refactor/Cleanup

* [MacOS] Add toolbar items support to NavigationPage

* [MacOS] Resize images for TabViewITems

* [MacOS] Fix TabbedPage resize issues , allow users to override some features when creating TVI

* [MacOS] Fix hide/show Navigation toolbar

* [MacOS] Redo CarouselPageRenderer with NSPageController

* [MacOS] Add support for Modal pages

* [MacOS] Refactor navigation from platform

* [Nuget] Add nuget for MacOS

* [Nuget]Fix nuspec

* [Nuget] Add variables for CI

* [Controls] Remove MainMenu from MacOS

* [MacOS] Add TableView renderer (no headers yet)

* [MacOS] Refactoring, marking extensions as internal

* [MacOS] Add group headers for TableViewRenderer

* [MacOS] Workaround for updates on listview collection

* [MacOS] Handle updates of rows in the ListViewRenderer properly

* [MacOS] Fix navigation animation

* Fix navigation header issues with modal pages

* [MacOS] Fix MDP issues with resizing

* [MacOS] Fix general dispose

* [MacOS] Add a ViewControllerWrapper for NSSplitView

* [MacOS] MDP renderer fix animation

* [MacOS] Fix ListView selection bug

* [MacOS] Fix rendering MDP Layout inside wrappers

* [MacOS] Re write the MainToolbar handler

* [MacOS] Don't use Sierra new extensions so we can run in stable channel

* [MacOS] Another way to hide the toolbar (smarter i think)

* [MacOS] Fix MDP bug and remove debug color

* [Controls] Add HanselForms sample

* [MacOS] Fix NRE WebviewRenderer

* [MacOS] Fix uneven rows on ListView renderer

* [MacOS] Fix NRE on load (can+t find the reason this happens)

* [MacOS] Fix uneven rows

* [MacOS] Fix header sizing on ListViewRenderer

* [Controls] More stuff on HanselForms

* [MacOS] Remove warning from ListViewRenderer

* [MacOS] Fix PageRenderer bug double init

* [MacOS] Don't calculate height if RowHeight is provided

* [Controls] More Hanselforms stuff

* [MacOS] Once again a new implementation for the NavigationBar, this time using a custom view to support BackgroundColor

* [MacOS] Fix build

* [MacOS] Refactoring AwesomeBar related controls

* Fix build

* [MacOS] NavigationBar update background and t test colors

* [MacOS] Fix when we remove navigation so it works when the NavigationRenderer wasn't removed from the parent controller like in a TabbedPage

* [MacOS] Add support for ListView  grouping

* [MacOS] Fix image extension method.

* [MacOS] Add base Maps project

* [MacOS] Export MapRenderer

* [MacOS] Add pin click and geocoderbacked for Maps

* [MacOS] Add extra binding project for API not in stable.

* [MacOS] Add MacOS Maps lib

* [MacOS]Fix build on alpha

* [MacOS] Remove MacOS Maps extra binding

* [UITest] Basic macOS setup

* [UITest] Add MacOSApp wrapper implementation

* [MacOS] Set AutomationID

* [UITests] Add ActionSheetUITests to MacOS UITest

* [MacOS] Fix bug on Picker

* [UITests] Link basic uitest basefixture and related files

* [MacOS] Fix pickers reuse

* [UItests] Fix MacOS app path

* [UITest] Ignore UItest for appearing on macOS for now

* [UITest] Update macOS for 2.0.3

* [UITest] Refactor EnterText MacOS app

* [UITest]Fix ViewQuery on MacOS

* [UITest]Fix IsEnabled UItest on macOS

* [UITest] Implement Enter, mark some tests inconclusive fix others

* [MacOS] Implement Entry Completed event

* [UITests] Fix UITest for IsVisible, ignore ToolbarItem test for now

* [UITests] Fix ISVisible again add extra category

* [Controls] Cleanup macOS gallery

* [MacOS] Fix Assembly info

* [Docs] Fix docs

* Fix build

* [Nuget] Fix nuspec

* [Controls] Link files on MacOS

* [Core] Update Forms stack before firing a event saying page was removed, possible breaking change

* [MacOS] Implement RemovePage on NavigationPAgeRenderer

* [UItest] Ignore some , implement back on MacOS UITest app

* [MacOS] Add default back button name (needs to be translated)

* [MacOS] Fix dispose

* [UITest] Make 29257 work on MacOS

* [MacOS] Rename stuff

* [MacOS] More renaming and cleanup

* [MacOS] Share implementations for iOS

* [MacOS] Reuse more IOS extensions

* [MacOS] Reuse FontExtensions

* [MacOS] Share NativeViewWrapper related stuff

* [MAcOS] Share event args and ExportRenderer

* [MacOS] Share platform effect

* [MacOS] Fix build

* [Docs]Fixing docs

* [MacOS] Fix ViewCell reuse

* [Core] Support ListView CachingStrategy on MacOS

* [MacOS] Fix issues with TextCell and ImageCell (we can’t set null to a NSControl value)

* [MacOS] Fix MDP child sizing bug
[UITest] Query marked by id and text

* [MacOS] Comment test related with context actions

* [MacOS] Implement missing stuff on ticker

* [MacOS] Make sure VisualElemenTracker calls the ticker update

* [UITests]Ignore context actions and not possible to test

* [MacOS] Fix Grouping bug on Listview

* [MacOS] Fix selection on Listview when using grouping

* [MacOS] Update navbar when page is popped

* [MacOS] Cleanup NavigationBar

* [Controls] More info on exceptions

* [MacOS] Fix bug animation pop modal

* [MacOS] Bring back BackgroundColor of NavigationBar

* [MacOS] Fix UITest animation delay

* [MacOS] Treat warnings as errors

* [MacOS] Center title on toolbar

* [Core] Add Platform configuration specific for MacOS

* [MacOS] Implement TabbedPage platform specific to handle TabItems on NavigationPage bar

* [MacOS] Fix warning

* [MacOS] Fix bug on SearchBar color

* [MacOS]Fix build

* [MacOS] remove extra dll from maps

* [Docs] Update docs

* [MacOS]Cleanup and refactoring

* Revert "[MacOS] remove extra dll from maps"

This reverts commit 73b9489.

* [MacOS] Fix wrong refactoring

* [MacOS] Remove gallery and uitest project

* [MacOS] dix formatting

* [MacOS] Remove extra stuff

* Merge branch 'master' into macOS-gallery

* [MacOS] Fix rebase

* [MacOS] Fix TargetPlatform

* fix docs

* [MacOS] Fix bug on TabbedPageRenderer no title

* [MacOS] Remove FormsNSView

* [MacOS] Cleanup on dispose on MDP renderer

* [MacOS] Update current page when source changes

* [MacOS] More cleanup

* [MacOS] Make sure we show the previous page when popping a Modal

* [MacOS] Fix issue with sizing the Header and visibility, remove for now header renderer reuse

* [MacOS] Clean CustomNSTableView

* [MacOS] Share LabelRenderer with iOS

* [MacOS] Share ResourcesProvider with iOS

* [MAcoS] Share VisualElementPackager with iOS

* [MacOS] Share ViewRenderer with iOS

* [MacOS] Merge with VisualElementTracker from iOS

* [MacOS] Merge with EventTracker from iOS

* [MacOS] Merge with VisualElementRenderer of iOS

* [MacOS] Make sure we always have a layer

* [MacOS] Fix Tracker merge with iOS version

* [MacOS] Fix bug with tabbed page on modal without navigation

* [Core] Rever change on core

* [MacOS] Clear renderers before setting them MDP

* [MacOS] Update tabbedPage ContainerArea

* [MacOS] Fix ListViewRenderer

* [MacOS] Make sure we don’t pass null to TextField string value

* [MacOS] Support for multiple clicks in same selected item on NSTableView

* [MacOS] Support Focus on EntryRenderer

* [MacOS] Fix index bug on TablevIewDataSource

* [MacOS] Fix SelectedItem TableViewDataSource

* [Nuget] Add Mac to Maps nuspec

* [Nuget]Fix path

* [macOS] Fixed Tab NSImage crash in TabbedPageRenderer (#705)

* [macOS] Fixed Tab NSImage crash in TabbedPageRenderer

* Coding Style

* Coding Style

* [MacOS] Fix previous merge with master

* [MacOS] Possible simple fix for click on views overlapping

* [MacOS] Rename to IsOnViewCell

* [MacOS] Cleanup, Address feedback from Samantha’s review

rmarinho added a commit that referenced this pull request Jan 27, 2017

Add MacOS gallery and UITest (#721)
* [MacOS] Cleanup

* [Controls] Add Header support to ListView

* [MacOS] NSView reuse on NSTableView

* [MacOS] Some fix on layour order

* [MacOS] Add CarouselPageRenderer

* [MacOS] Implement EventTracker on PageRenderer

* [MacOS] Cleanup CarouselPageRenderer

* [MacOS] Add MasterDetailPage renderer

* [MacOS] MDP renderer don't allow drag of splitter

* [MacOS] Add TabbedPage renderer

* [MacOS] Initial sketch of NavigationPageRenderer

* [MacOS] Send disappearing of CurrentPage on Dispose on NavigationPageRenderer

* [MacOS] Add Gallery page for Mac

* [MacOS] Add MacOSExpressionSearch

* [MacOS] Fix ColorExtension

* [MacOS] Fix MDP renderer layout

* [MacOS] Implement native selection on ListViewRenderer

* [MacOS] Deselect a item on NSTableView

* [MacOS] Remove previous SplitViewItems

* [MacOS] Fix navigationpage height

* [MacOS] Add toolbar for NavigationPageRenderer

* [MacOS] Don't remove selection for now (crashing)

* [MacOS] Refactor page and back button title on NavigationPageRenderer

* [MacOS] Fix bug when native navigate back

* [MacOS] Hide layer when transition

* [MacOS] ListviewRenderer fix BbackgroundColor

* [MacOS] Fix background on ScrollViewRenderer

* [MacOS] Fix header measure on ListViewRenderer

* [MacOS] Add Mac twitter demo

* [Controls] Spaces for easy reading

* [MacOS] More xaml cleanup

* [Core] Add Mac as aTargetPlatform

* [MacOS] Add alerts and actionsheets

* [MacOS] Add GestureRecognizers

* [MacOS] Fix Layout issues when adding children, enable transformations

* [MacOS] Fix title on tab item, move to tabbed navigation based on segmented control

* [MacOS] Hide toolbar when not needed, this allows to work with tabbed page, cleanup

* [MacOS] Add NativeBindings and NativeViewWrapper

* [MacOS] Fix AssemblyInfo

* [MacOS] FIX NRE on SetBackgroundColor BoxView

* [MacOS] Fix NavigationPageRenderer

* [MacOS] Fix build

* [MacOS] Also update page when it resizes

* [MacOS] Add LayoutRenderer for handle items position when the bounds change.

* [MacOS] Refactor/Cleanup

* [MacOS] Add toolbar items support to NavigationPage

* [MacOS] Resize images for TabViewITems

* [MacOS] Fix TabbedPage resize issues , allow users to override some features when creating TVI

* [MacOS] Fix hide/show Navigation toolbar

* [MacOS] Redo CarouselPageRenderer with NSPageController

* [MacOS] Add support for Modal pages

* [MacOS] Refactor navigation from platform

* [Nuget] Add nuget for MacOS

* [Nuget]Fix nuspec

* [Nuget] Add variables for CI

* [Controls] Remove MainMenu from MacOS

* [MacOS] Add TableView renderer (no headers yet)

* [MacOS] Refactoring, marking extensions as internal

* [MacOS] Add group headers for TableViewRenderer

* [MacOS] Workaround for updates on listview collection

* [MacOS] Handle updates of rows in the ListViewRenderer properly

* [MacOS] Fix navigation animation

* Fix navigation header issues with modal pages

* [MacOS] Fix MDP issues with resizing

* [MacOS] Fix general dispose

* [MacOS] Add a ViewControllerWrapper for NSSplitView

* [MacOS] MDP renderer fix animation

* [MacOS] Fix ListView selection bug

* [MacOS] Fix rendering MDP Layout inside wrappers

* [MacOS] Re write the MainToolbar handler

* [MacOS] Don't use Sierra new extensions so we can run in stable channel

* [MacOS] Another way to hide the toolbar (smarter i think)

* [MacOS] Fix MDP bug and remove debug color

* [Controls] Add HanselForms sample

* [MacOS] Fix NRE WebviewRenderer

* [MacOS] Fix uneven rows on ListView renderer

* [MacOS] Fix NRE on load (can+t find the reason this happens)

* [MacOS] Fix uneven rows

* [MacOS] Fix header sizing on ListViewRenderer

* [Controls] More stuff on HanselForms

* [MacOS] Remove warning from ListViewRenderer

* [MacOS] Fix PageRenderer bug double init

* [MacOS] Don't calculate height if RowHeight is provided

* [Controls] More Hanselforms stuff

* [MacOS] Once again a new implementation for the NavigationBar, this time using a custom view to support BackgroundColor

* [MacOS] Fix build

* [MacOS] Refactoring AwesomeBar related controls

* Fix build

* [MacOS] NavigationBar update background and t test colors

* [MacOS] Fix when we remove navigation so it works when the NavigationRenderer wasn't removed from the parent controller like in a TabbedPage

* [MacOS] Add support for ListView  grouping

* [MacOS] Fix image extension method.

* [MacOS] Add base Maps project

* [MacOS] Export MapRenderer

* [MacOS] Add pin click and geocoderbacked for Maps

* [MacOS] Add extra binding project for API not in stable.

* [MacOS] Add MacOS Maps lib

* [MacOS]Fix build on alpha

* [MacOS] Remove MacOS Maps extra binding

* [UITest] Basic macOS setup

* [UITest] Add MacOSApp wrapper implementation

* [MacOS] Set AutomationID

* [UITests] Add ActionSheetUITests to MacOS UITest

* [MacOS] Fix bug on Picker

* [UITests] Link basic uitest basefixture and related files

* [MacOS] Fix pickers reuse

* [UItests] Fix MacOS app path

* [UITest] Ignore UItest for appearing on macOS for now

* [UITest] Update macOS for 2.0.3

* [UITest] Refactor EnterText MacOS app

* [UITest]Fix ViewQuery on MacOS

* [UITest]Fix IsEnabled UItest on macOS

* [UITest] Implement Enter, mark some tests inconclusive fix others

* [MacOS] Implement Entry Completed event

* [UITests] Fix UITest for IsVisible, ignore ToolbarItem test for now

* [UITests] Fix ISVisible again add extra category

* [Controls] Cleanup macOS gallery

* [MacOS] Fix Assembly info

* [Docs] Fix docs

* Fix build

* [Nuget] Fix nuspec

* [Controls] Link files on MacOS

* [Core] Update Forms stack before firing a event saying page was removed, possible breaking change

* [MacOS] Implement RemovePage on NavigationPAgeRenderer

* [UItest] Ignore some , implement back on MacOS UITest app

* [MacOS] Add default back button name (needs to be translated)

* [MacOS] Fix dispose

* [UITest] Make 29257 work on MacOS

* [MacOS] Rename stuff

* [MacOS] More renaming and cleanup

* [MacOS] Share implementations for iOS

* [MacOS] Reuse more IOS extensions

* [MacOS] Reuse FontExtensions

* [MacOS] Share NativeViewWrapper related stuff

* [MAcOS] Share event args and ExportRenderer

* [MacOS] Share platform effect

* [MacOS] Fix build

* [Docs]Fixing docs

* [MacOS] Fix ViewCell reuse

* [Core] Support ListView CachingStrategy on MacOS

* [MacOS] Fix issues with TextCell and ImageCell (we can’t set null to a NSControl value)

* [MacOS] Fix MDP child sizing bug
[UITest] Query marked by id and text

* [MacOS] Comment test related with context actions

* [MacOS] Implement missing stuff on ticker

* [MacOS] Make sure VisualElemenTracker calls the ticker update

* [UITests]Ignore context actions and not possible to test

* [MacOS] Fix Grouping bug on Listview

* [MacOS] Fix selection on Listview when using grouping

* [MacOS] Update navbar when page is popped

* [MacOS] Cleanup NavigationBar

* [Controls] More info on exceptions

* [MacOS] Fix bug animation pop modal

* [MacOS] Bring back BackgroundColor of NavigationBar

* [MacOS] Fix UITest animation delay

* [MacOS] Treat warnings as errors

* [MacOS] Center title on toolbar

* [Core] Add Platform configuration specific for MacOS

* [MacOS] Implement TabbedPage platform specific to handle TabItems on NavigationPage bar

* [MacOS] Fix warning

* [MacOS] Fix bug on SearchBar color

* [MacOS]Fix build

* [MacOS] remove extra dll from maps

* [Docs] Update docs

* [MacOS]Cleanup and refactoring

* Revert "[MacOS] remove extra dll from maps"

This reverts commit 73b9489.

* [MacOS] Fix wrong refactoring

* [MacOS] dix formatting

* [MacOS] Fix build

* [MacOS] Fix bug on TabbedPageRenderer no title

* [MacOS,UITest] Update packages

* [MacOS ,UITest] Add delay when tapping something, and focus with double click

* [MacOS,UITest] Ignore UITest, not possible to test with current version

* [MacOS,UITest] Ignore test that uses Frame, UITest doesn’t return it

* [MacOS] Fix bug when no title on toolbar items

* [MacOS] Remove FormsNSView

* [MacOS] Cleanup on dispose on MDP renderer

* [MacOS] Different way to test leak of MDP, need to look at this again after

* [MacOS] Update current page when source changes

* [MacOS] More cleanup

* [MacOS,UITest] Implement ClearText

* [MacOS,UITest] ClearText doesn’t work for now on MacOS uitest

* [MacOS] Make sure we show the previous page when popping a Modal

* [MacOS] Fix issue with sizing the Header and visibility, remove for now header renderer reuse

* [MacOS] Clean CustomNSTableView

* [MacOS] Share LabelRenderer with iOS

* [MacOS,UITest] Don’t try to scroll for the element

* [MacOS] Share ResourcesProvider with iOS

* [MAcoS] Share VisualElementPackager with iOS

* [MacOS] Share ViewRenderer with iOS

* [MacOS] Merge with VisualElementTracker from iOS

* [MacOS] Merge with EventTracker from iOS

* [MacOS] Merge with VisualElementRenderer of iOS

* [MacOS] Make sure we always have a layer

* [MacOS] Fix Tracker merge with iOS version

* [MacOS] Fix bug with tabbed page on modal without navigation

* [Core] Rever change on core

* [Controls] Add missing image

* [MacOS] Clear renderers before setting them MDP

* [MacOS] Update tabbedPage ContainerArea

* [Controls] Add Custom renderers tests

* [MacOS] Fix ListViewRenderer

* [MacOS,UITest] Refactoring, implement index

* [MacOS] Make sure we don’t pass null to TextField string value

* [MacOS] Support for multiple clicks in same selected item on NSTableView

* [MacOS, UITest] Fix bug on Back because of refactoring

* [MacOS,UITest] Ignore UITest because we’d-not have ScrollDownTo yet

* [MacOS] Support Focus on EntryRenderer

* [MacOS,UITest] Ignore more a couple of tests that we can’t test on UITest Desktop

* [MacOS,UITest] MacOSApp looks for StaticText fields too

* [MacOS, UITest] Fix EnterText for marked Entry

* [MacOS] Fix index bug on TablevIewDataSource

* [MacOS] Fix SelectedItem TableViewDataSource

* [Nuget] Add Mac to Maps nuspec

* [Nuget]Fix path

* [Controls] Add basic FormsGallery sample

* [macOS] Fixed Tab NSImage crash in TabbedPageRenderer (#705)

* [macOS] Fixed Tab NSImage crash in TabbedPageRenderer

* Coding Style

* Coding Style

* [MacOS] Fix previous merge with master

* [MacOS] Possible simple fix for click on views overlapping

* [UItest] Ignore this part of the test we can’t click on NSViews yet

* [MacOS] Rename to IsOnViewCell

* fix docs

* [MacOS] Cleanup, Address feedback from Samantha’s review

* [MacOS] Add ContextActions

* [Controls] Remove FormsGalery for now

* [Docs] Update docs

* [MacOS] Implement ContextActions

* [MacOS,UITests] Enable and support UITests of ContextActions

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment