Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Conversation

@StephaneDelcroix
Copy link
Member

@StephaneDelcroix StephaneDelcroix commented Jun 1, 2017

Description of Change

this

Accessibility.LabeledBy="label"

is now a shortcut for

Accessibility.LabeledBy="{x:Reference label}"

The tests will fail until this is rebased on top of #913

this is #914 against 3.0

Bugs Fixed

/

API Changes

Moved:

  • Xamarin.Forms.Xaml.Internals.INameScopeProvider from Xaml to Core, with additional type forwarding for backward compat

Added:

  • class ReferenceTypeConverter

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@rmarinho
Copy link
Member

Can we rebase this @StephaneDelcroix ?

@StephaneDelcroix
Copy link
Member Author

rebasing won't fix this

@samhouts samhouts changed the title Allow specifying Accessibility.LabeledBy by name [Xaml] Allow specifying Accessibility.LabeledBy by name Aug 23, 2017
@samhouts samhouts closed this Nov 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants