Revamp Mac theming #493
Revamp Mac theming #493
Conversation
This commit: - Drops outdated CG* editors - Drops ThemeManager - Introduces IHostResourceProvider - Moves all images to new API - Starts implementing colors
This fixes foreground color for this view not changing when a row containing it is selected
This fixes an issue where a transparent background would bleed a popup's background through rather than the view or layers below it. Also tweak sizes to fit everything.
|
|
||
| public override void ViewDidChangeEffectiveAppearance () | ||
| { | ||
| this.propertyArrangeMode.Font = HostResourceProvider.GetNamedFont (PropertyEditorControl.DefaultFontName, PropertyEditorControl.DefaultFontSize); |
There was a problem hiding this comment.
Ran the project for the first time and this.property* are all null, so getting an NRE exception on start-up.
CartBlanche
left a comment
CartBlanche
left a comment
There was a problem hiding this comment.
Getting NRE on start-up.
Seems Mojave calls ViewDidChangeEffectiveAppearance in NSView.ctor (NSCoder) where High Sierra did not. We'll just ignore appearance changes until we're setup.
|
On Mojave dark mode with the light theme selected, the color popup background isn't set and appears dark, making the selected tab icon hard to read. |
|
Selecting "Resource" in the property dropdown for the material design brush in the standalone causes a missins method exception in |
|
Starting from a brush set to no brush, and selecting MD, we get multiple selections, the brush isn't getting updated: |
|
Should up/down controls have a rollover effect when they are disabled? (check it out on read-only properties). |
|
There's still some slight differences in the design, but they're not worth blocking on. Former comments should be addressed. The brush issues exist in master. |
This introduces new APIs for providing Mac theme images, colors and themes. Additionally it updates the brush editors to more closely (but not yet completely) match the design docs using these APIs (and some layout tweaks). Checkout and test requested.
Before:
After:
Dark mode will not look correct in the standalone in <=High Sierra. This is known.