xapi-backtrace: add support for ppx_sexp_conv.v0.11.0#14
Merged
mseri merged 1 commit intoxapi-project:masterfrom May 16, 2018
mseri:master
Merged
xapi-backtrace: add support for ppx_sexp_conv.v0.11.0#14mseri merged 1 commit intoxapi-project:masterfrom mseri:master
mseri merged 1 commit intoxapi-project:masterfrom
mseri:master
Conversation
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
lindig
approved these changes
May 16, 2018
Contributor
lindig
left a comment
lindig
left a comment
There was a problem hiding this comment.
This fixes an escape and and makes a runtime dependency more explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be released with or after xapi-project/xs-opam#268 is merged, and then we can get rid of the current patch in that PR
Signed-off-by: Marcello Seri marcello.seri@citrix.com