design: Xapi should process events from xenopsd in a timely manner #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
gaborigloi
reviewed
May 26, 2017
| as started during a bootstorm. | ||
| It can happen that the VM is able to send UDP packets already, but XAPI still reports it as not started for minutes. | ||
|
|
||
| XAPI currently processes all events from xenopsd in a single thread, the unpause |
There was a problem hiding this comment.
I assume the relevant code that processes events from xenopsd in xapi is somewhere here: https://github.com/xapi-project/xen-api/blob/master/ocaml/xapi/xapi_xenops.ml#L1204
There was a problem hiding this comment.
The event loop for xenopsd->xapi is here in events_watch: https://github.com/xapi-project/xen-api/blob/master/ocaml/xapi/xapi_xenops.ml#L1919, and it calls the module you mentioned.
gaborigloi
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This briefly explains the goal behind the refactoring PR, and the XAPI side of the changes.
See also the Event handling in the Control Plane - Xapi, Xenopsd and Xenstore written by @mg12.