Make coverage.sh work with dune#2
Merged
gaborigloi merged 1 commit intoxapi-project:masterfrom Aug 7, 2018
gaborigloi:dune_coverage
Merged
Make coverage.sh work with dune#2gaborigloi merged 1 commit intoxapi-project:masterfrom gaborigloi:dune_coverage
gaborigloi merged 1 commit intoxapi-project:masterfrom
gaborigloi:dune_coverage
Conversation
lindig
approved these changes
Aug 7, 2018
lindig
left a comment
lindig
left a comment
There was a problem hiding this comment.
Looking good. Just one comment about something that was already there.
coverage.sh
Outdated
|
|
||
| # copy over everything | ||
| $(which cp) -r ../* . | ||
| $(which cp) -r ./* $COVERAGE_DIR |
There was a problem hiding this comment.
The which cp seems strange to me. Why not use /bin/cp or simply cp? I don't understand why it is here.
Contributor
Author
There was a problem hiding this comment.
I have no idea to be honest, I also found this surprising.
Contributor
Author
There was a problem hiding this comment.
I've changed it after discussion with people - which is pointless
When I've converted nbd to dune, coverage.sh started failing with this error: From the command line: Error: Don't know about directory .coverage! Apparently dune doesn't like it when we nest a project inside itself. So I've changed the coverage directory to be a temporary dir in /tmp - this works fine with dune. Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I've converted nbd to dune, coverage.sh started failing with this
error:
From the command line:
Error: Don't know about directory .coverage!
Apparently dune doesn't like it when we nest a project inside itself. So
I've changed the coverage directory to be a temporary dir in /tmp - this
works fine with dune.
Signed-off-by: Gabor Igloi gabor.igloi@citrix.com