CA-144941: Don't checksum the gpg binary #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Forward port of #1931. |
simonjbeaumont
force-pushed
the
ca-144941
branch
from
6ae4b67 to
f32b606
Compare
We are already checking the signature of the patch contents, it seems silly to also checksum the gpg binary itself. It's also becoming a bit of a maintenance burden and cumbersome in the open source world where this checksum will be different on every version of every distro. Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>
Contributor
|
Let's do it! |
johnelse
added a commit
that referenced
this pull request
Sep 12, 2014
CA-144941: Don't checksum the gpg binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are already checking the signature of the patch contents, it seems silly to
also checksum the gpg binary itself. It's also becoming a bit of a maintenance
burned and cumbersome in the open source world where this checksum will be
different on every version of every distro.
Signed-off-by: Si Beaumont simon.beaumont@citrix.com