CA-115557: networkd: implement enic workaround #1956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks as if it should work fine. A couple of fairly trivial points: For ease of understanding the code in future, I think
next to that checking-function. |
Member
Author
|
@thomassa Thanks, I'll make those changes. |
When on the Linux bridge backend and when the "enic" driver is loaded, we need to apply a workaround (implemented in the following commit). The enic driver is for Cisco UCS devices. The current driver adds VLAN0 headers to all incoming packets, which confuses certain guests OSes. The workaround constitutes added a VLAN0 Linux device to strip those headers again. The patch moves the "backend_kind" ref outside the Bridge module, and adds an "need_enic_workaround" function. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
When the enic workaround needs to be applied (according to the check implemented in the previous commit), then when asked to add an interface to a bridge, create a VLAN0 device for the given interface, and add that to the bridge instead. This applies to bonded interfaces as well as individual ones (we simply add the VLAN0 device on top of the bond device). Also, in Interface.make_config, we need to take care to configure both the base device as well as the VLAN0 device with the same parameters. Finally, when destroying a bridge with a VLAN0 bond, we need to destroy the bond device as well. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Member
Author
|
@thomassa I have now updated the commits. |
thomassa
added a commit
that referenced
this pull request
Sep 22, 2014
CA-115557: networkd: implement enic workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.