CP-13301 full implementation of xenprep_start #2332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
OK, so apart from the |
ocaml/xapi/xapi_vm.ml
Outdated
Contributor
Author
There was a problem hiding this comment.
On second thoughts, I think I can replace this with just
Xapi_vbd.insert ~__context ~vbd:cd_vbd ~vdi;
instead of using Helpers.call_api_functions.
Member
There was a problem hiding this comment.
I'd avoid that, just to be sure, because you would bypass the "operations" handling in Message_forwarding.
This new convenience function fails if there are zero or multiple SRs that appear to be Tools SRs. It memoises its result, so calls after the first one will be quick and cheap. Signed-off-by: Thomas Sanders <thomas.sanders@citrix.com>
Just for peace of mind, add a test that the SR content_type is "iso". Signed-off-by: Thomas Sanders <thomas.sanders@citrix.com>
thomassa
force-pushed
the
xenprep-start
branch
from
17c294d to
56381fd
Compare
Contributor
Author
|
I've squashed commits, and added and used a |
thomassa
force-pushed
the
xenprep-start
branch
from
56381fd to
91ad7eb
Compare
thomassa
force-pushed
the
xenprep-start
branch
from
91ad7eb to
70c0f2d
Compare
The xenprep ISO is not yet available, so for the time being we insert the tools ISO for dev-testing purposes. The ISO is inserted into any empty virtual CD drive. If there is no such VBD, a newly-defined error is raised: vm_no_empty_cd_vbd Signed-off-by: Thomas Sanders <thomas.sanders@citrix.com>
Signed-off-by: Thomas Sanders <thomas.sanders@citrix.com>
thomassa
force-pushed
the
xenprep-start
branch
from
c0db7d1 to
6a4be8d
Compare
Contributor
Author
|
And I've made the code remove the other-config entry if it fails to find and insert the CD. |
Contributor
|
@xen-git: retest this please. |
Member
|
Looks good now. |
robhoes
added a commit
that referenced
this pull request
Aug 13, 2015
CP-13301 full implementation of xenprep_start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the
xenprep_startpart of the design athttps://github.com/xapi-project/xapi-project.github.io/blob/master/xapi/futures/xenprep.md
The xenprep ISO is not yet available, so for the time being we insert
the tools ISO for dev-testing purposes.