-
Notifications
You must be signed in to change notification settings - Fork 294
markdown: more tweaks #3124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markdown: more tweaks #3124
Conversation
| Apart from the RPCs enumerated above, some classes have additional RPCs | ||
| associated with them. For example, the `VM` class has RPCs for cloning, | ||
| suspending, starting etc. Such additional RPCs are described explicitly | ||
| in the API reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what changed here ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added newline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😛
ocaml/doc/wire-protocol.md
Outdated
| `int`, and in each case the keys of the maps are stringified as | ||
| above. For example, the `(string -> double) map` containing the mappings | ||
| _Mike → 2.3_ and _John → 1.2_ would be represented as: | ||
| _Mike -> 2.3_ and _John -> 1.2_ would be represented as: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the arrow here appear properly without being interpreted in weird markdown related ways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the html notation in normal (non code-block) text is safer - what is the reason for changing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look on my screen 👀 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it seems the output differs per system... No problem. If I remember well there are some more instances of → in the markdown_backend.ml you may want to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see one more indeed...
Btw, I'm also trying out the unicode character (→).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the difference per system we may be safer with -> after all; or even -> presuming the latter looks ok for you (may be worth double-checking the rest of the escaped characters in markdown_backen.ml).
| ['OpaqueRef:1', 'OpaqueRef:2', 'OpaqueRef:3', 'OpaqueRef:4' ] | ||
| >>> records['OpaqueRef:1']['name_label'] | ||
| 'Red Hat Enterprise Linux 7' | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's another funny change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😛
kc284
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, happy with it - could you also squash the commits (which I forgot to do when I merged the previous PR)
The `→` code does not become an arrow when I build the PDF. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
This ensures that chapter headings appear correctly. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
No description provided.