Skip to content

Conversation

@robhoes
Copy link
Member

@robhoes robhoes commented Jul 5, 2017

No description provided.

@robhoes robhoes requested a review from kc284 July 5, 2017 13:40
Apart from the RPCs enumerated above, some classes have additional RPCs
associated with them. For example, the `VM` class has RPCs for cloning,
suspending, starting etc. Such additional RPCs are described explicitly
in the API reference.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what changed here ??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added newline.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😛

`int`, and in each case the keys of the maps are stringified as
above. For example, the `(string -> double) map` containing the mappings
_Mike → 2.3_ and _John → 1.2_ would be represented as:
_Mike -> 2.3_ and _John -> 1.2_ would be represented as:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the arrow here appear properly without being interpreted in weird markdown related ways?

Copy link

@kc284 kc284 Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the html notation in normal (non code-block) text is safer - what is the reason for changing it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look on my screen 👀 :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems the output differs per system... No problem. If I remember well there are some more instances of → in the markdown_backend.ml you may want to change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see one more indeed...
Btw, I'm also trying out the unicode character (→).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the difference per system we may be safer with -> after all; or even -> presuming the latter looks ok for you (may be worth double-checking the rest of the escaped characters in markdown_backen.ml).

['OpaqueRef:1', 'OpaqueRef:2', 'OpaqueRef:3', 'OpaqueRef:4' ]
>>> records['OpaqueRef:1']['name_label']
'Red Hat Enterprise Linux 7'
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's another funny change!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same :)

Copy link
Contributor

@mseri mseri Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😛

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 14.76% when pulling 93bb8e8 on robhoes:master into ea72282 on xapi-project:master.

Copy link

@kc284 kc284 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, happy with it - could you also squash the commits (which I forgot to do when I merged the previous PR)

robhoes added 2 commits July 5, 2017 15:45
The `→` code does not become an arrow when I build the PDF.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
This ensures that chapter headings appear correctly.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 14.746% when pulling 0597d00 on robhoes:master into 226ce4d on xapi-project:master.

@robhoes robhoes merged commit e378500 into xapi-project:master Jul 5, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 14.759% when pulling 0597d00 on robhoes:master into 226ce4d on xapi-project:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants